to_chars: migrating from custom switch to __cpp_lib_to_chars
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterbrereton
force-pushed
the
fosterbrereton/to_string-take-3
branch
from
97ca8b0
to
8ef42e6
Compare
|
Tests are finally passing on all platforms. @sean-parent and @camio this one is ready for review. |
fosterbrereton
changed the title
__cpp_lib_to_charsto_chars: migrating from custom switch to __cpp_lib_to_chars
sean-parent
reviewed
Jun 26, 2024
| @@ -1,39 +1,21 @@ | |||
| { | |||
| "name": "adobe-source-libraries", | |||
| "version": "1.0.45", | |||
There was a problem hiding this comment.
Does that version number need to be updated when we do a release? Is that document?
There was a problem hiding this comment.
I have no idea. I took that line verbatim from what's in main today. I'd ask @camio for details there.
sean-parent
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the flag
ADOBE_HAS_TO_CHARS_FPwas derived from the existence (or lack) of a macOS-dependent preprocessor macro, which turned out to be flaky for the purposes of deciding ifto_charsis available for use or not.This PR instead switches the check to use the more standard
defined(__cpp_lib_to_chars) >= 201611L. All checks of this switch have also been moved to source files to eliminate ODR violations. I commandeered the defunctstring.cppfile to be the home of theto_stringimplementation.