Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix defaultThemeMap: add accentColor to default to support colors #1110

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

xDellTog
Copy link

@xDellTog xDellTog commented Oct 26, 2022

Hi there! I don't know if that's an issue or a possible feature, but I will consider an issue.

Recently I used accentColor in my theme, to customize a native checkbox and Stitches don't apply the color in final CSS, so I added accentColor in defaultThemeMap to property support theme colors and it works.
I used MDN Web Docs syntax and description to doc.

Works

accentColor: 'red'

Failure

accentColor: '$primaryColor'

Sandbox to Test

I hope it can be fixed, Thanks!

@prclm
Copy link

prclm commented Aug 21, 2023

could you remove all the auto formatting changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants