ENH: Email users on a HV workflow #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server properties previously using host id as hv id however hosts are different to hvs
Action takes a hv name and sends email to users with VMs on that hv Test email templates
Test for sending hv emails workflow
Update tests to change server property from HYPERVISOR_ID to HYPERVISOR_NAME
anish-mudaraddi
requested changes
Sep 26, 2024
| @@ -0,0 +1,9 @@ | |||
| Dear Cloud User {{username}}, <br/><br/> | |||
|
|
|||
| Test email about servers on hv <br/><br/><br/> | |||
There was a problem hiding this comment.
@jacob-ward @DavidFair - What should the email template be here? Worth getting this nailed down before merging this into Prod
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 98.20% 98.25% +0.05%
==========================================
Files 195 197 +2
Lines 7636 7860 +224
Branches 460 468 +8
==========================================
+ Hits 7499 7723 +224
Misses 110 110
Partials 27 27 ☔ View full report in Codecov by Sentry. |
anish-mudaraddi
previously approved these changes
Sep 26, 2024
gmatthews20
force-pushed
the
hv_notify
branch
from
744c3f0
to
29613d8
Compare
anish-mudaraddi
previously approved these changes
Sep 26, 2024
Update docs and actions using server properties to use hypervisor name instead of hypervisor id
gmatthews20
force-pushed
the
hv_notify
branch
from
29613d8
to
8599ef9
Compare
anish-mudaraddi
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add workflow for emailing users on a given hypervisor, test temporary email template. Tests for the new workflow
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?