Skip to content

Commit

Permalink
Changed apptainer def file name
Browse files Browse the repository at this point in the history
Changed hepscore .def to apptainer.def. This should be done consistently for any future singularity def files, to keep the logic for listing and pushing them the same as Dockerfiles.
  • Loading branch information
AdamG412 committed Oct 4, 2023
1 parent 2807307 commit 13706ed
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build_images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
find -name Dockerfile | sed -r 's#\./(.+)/Dockerfile#\1#g' | jq -Rsc 'split("\n")[:-1]'
)" >> $GITHUB_OUTPUT
echo "apptainer-images=$(
find -name *.def | sed -r 's#\./(.+)(\.def)#\1#g' | jq -Rsc 'split("\n")[:-1]'
find -name apptainer.def | sed -r 's#\./(.+)(\/apptainer\.def)#\1#g' | jq -Rsc 'split("\n")[:-1]'
)" >> $GITHUB_OUTPUT
echo "sha_short=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
outputs:
Expand Down Expand Up @@ -89,13 +89,13 @@ jobs:
- name: Build apptainer & push to prod
if: ${{ github.ref == 'refs/heads/master' }}
run: |
singularity build container.sif ${{ matrix.image }}.def
singularity build container.sif ${{ matrix.image }}/apptainer.def
singularity push container.sif harbor.stfc.ac.uk/stfc-cloud/${{ matrix.image }}:${{ needs.setup.outputs.sha }}
- name: Build apptainer & push to staging
if: ${{ github.ref != 'refs/heads/master' }}
run: |
singularity build container.sif ${{ matrix.image }}.def
singularity build container.sif ${{ matrix.image }}/apptainer.def
singularity push container.sif harbor.stfc.ac.uk/stfc-cloud-staging/${{ matrix.image }}:${{ needs.setup.outputs.sha }}
- name: Inform of tagged name apptainer
Expand Down
File renamed without changes.

0 comments on commit 13706ed

Please sign in to comment.