(Closes #2755) Bug fix for psyad failing to transform array assignment #2767
+102
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2767 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 354 354
Lines 49021 49025 +4
=======================================
+ Hits 48957 48961 +4
Misses 64 64 ☔ View full report in Codecov by Sentry. |
|
This needs a 'science' review by @DrTVockerodtMO and then I'll put it up for proper code review. |
Will be happy to, just need to figure out how to test specific branches on our system and I'll have a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that (pleasingly) only involved me updating some code to remove an old restriction. @DrTVockerodtMO please could you try this branch and let me know whether it solves your problem?