Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2265 rename split dyn stencil #2266
2265 rename split dyn stencil #2266
Changes from 5 commits
2ca043c
ce2a6a9
5d25a1b
df1ad1d
be120f3
9fba2af
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this class, it seems to me we could do without it and have a NamedTuple instead:
I say this because none of the setters do any validation. Can @rupertford, @TeranIvy or @hiker see any potential problem with doing that? (e.g. is this class likely to need significant additional functionality in future?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arporter, I think that the potential future functionality would be "more of the same" in the sense of more stencil types, but the underlying mechanism wouldn't change. If doing away with the class doesn't affect adding more stencil types then I'm fine with it!