-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2263 splitting LFRic scalar args #2264
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2264 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 342 343 +1
Lines 46069 46077 +8
=======================================
+ Hits 45998 46006 +8
Misses 71 71
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! There are some minor comments and clean-ups (see inline).
Tests with compilation work and examples pass. I didn't check documentation in this instance, but grepping for LFRicScalarArgs
only returns source and test changes so I think we're fine here.
Also, the branch needs updating with master. I'd advise doing that in a separate commit to review corrections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All review comments are addressed. Tests with compilation pass except for an unrelated test. It is not the fault of this PR and it is exposed by using GCC 11.2.0 compiler which is stricter in syntax.
Documentation builds fine. Examples run.
After updating the user guide and changelog I will proceed to merge the branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI passed, proceeding to merge.
closes #2263