-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2245 Splitting LFRicLoopBounds from dynamo0p3.py #2260
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2260 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 337 338 +1
Lines 45900 45907 +7
=======================================
+ Hits 45829 45836 +7
Misses 71 71
☔ View full report in Codecov by Sentry. |
Added more imported functions to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this Oakley.
Just a few minor things to address.
The link check and doctest failures are not the fault of this PR. The former is just a timeout on a valid URL and the latter only happens for me once I've upgraded Sphinx. I'll open a new issue for it.
Ref. guide builds fine.
Functionality is unchanged.
Please see https://github.com/stfc/PSyclone/wiki/CodeReview for how to respond to the review. Thanks :-)
Hi @oakleybrunt, is this ready for review again now? |
@arporter Apologies. Yes, it is ready for review. I've added the label and won't forget on the next PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there now.
Docstrings need a bit more work.
I've triggered the integration tests so will check those next time.
…lone into 2245_splitting_lfricloopbounds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes have been made.
Ref. guide builds fine.
Integration tests are fine.
Will proceed to merge.
closes #2245