Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2245 Splitting LFRicLoopBounds from dynamo0p3.py #2260

Merged
merged 12 commits into from
Aug 30, 2023

Conversation

oakleybrunt
Copy link
Collaborator

closes #2245

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0b149bc) 99.84% compared to head (9af0292) 99.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2260   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         337      338    +1     
  Lines       45900    45907    +7     
=======================================
+ Hits        45829    45836    +7     
  Misses         71       71           
Files Changed Coverage Δ
src/psyclone/dynamo0p3.py 99.82% <ø> (-0.01%) ⬇️
src/psyclone/domain/lfric/__init__.py 100.00% <100.00%> (ø)
src/psyclone/domain/lfric/lfric_invoke.py 100.00% <100.00%> (ø)
src/psyclone/domain/lfric/lfric_loop_bounds.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oakleybrunt
Copy link
Collaborator Author

oakleybrunt commented Aug 14, 2023

Added more imported functions to the __all__ attribute in src/psyclone/__init__.py

@mo-lottieturner
Copy link
Collaborator

#2235

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this Oakley.
Just a few minor things to address.
The link check and doctest failures are not the fault of this PR. The former is just a timeout on a valid URL and the latter only happens for me once I've upgraded Sphinx. I'll open a new issue for it.
Ref. guide builds fine.
Functionality is unchanged.
Please see https://github.com/stfc/PSyclone/wiki/CodeReview for how to respond to the review. Thanks :-)

src/psyclone/domain/lfric/__init__.py Outdated Show resolved Hide resolved
src/psyclone/domain/lfric/lfric_loop_bounds.py Outdated Show resolved Hide resolved
src/psyclone/domain/lfric/lfric_loop_bounds.py Outdated Show resolved Hide resolved
src/psyclone/tests/domain/lfric/lfric_loop_bounds_test.py Outdated Show resolved Hide resolved
@arporter
Copy link
Member

Hi @oakleybrunt, is this ready for review again now?

@oakleybrunt
Copy link
Collaborator Author

@arporter Apologies. Yes, it is ready for review. I've added the label and won't forget on the next PR!

@arporter arporter temporarily deployed to integration August 25, 2023 08:03 — with GitHub Actions Inactive
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there now.
Docstrings need a bit more work.
I've triggered the integration tests so will check those next time.

src/psyclone/domain/lfric/lfric_loop_bounds.py Outdated Show resolved Hide resolved
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes have been made.
Ref. guide builds fine.
Integration tests are fine.
Will proceed to merge.

@arporter arporter merged commit ba74775 into master Aug 30, 2023
11 checks passed
@arporter arporter deleted the 2245_splitting_lfricloopbounds branch August 30, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitting LFRicLoopBounds from src/psyclone/dynamo0p3.py
3 participants