-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting LFRicLoopBounds from src/psyclone/dynamo0p3.py
#2245
Labels
good first issue
An issue that is probably suitable for a new PSyclone developer
LFRic
Issue relates to the LFRic domain
Comments
mo-lottieturner
added
LFRic
Issue relates to the LFRic domain
good first issue
An issue that is probably suitable for a new PSyclone developer
labels
Aug 4, 2023
oakleybrunt
added a commit
that referenced
this issue
Aug 14, 2023
oakleybrunt
added a commit
that referenced
this issue
Aug 14, 2023
oakleybrunt
added a commit
that referenced
this issue
Aug 14, 2023
oakleybrunt
added a commit
that referenced
this issue
Aug 23, 2023
oakleybrunt
added a commit
that referenced
this issue
Aug 25, 2023
arporter
added a commit
that referenced
this issue
Aug 30, 2023
#2245 Splitting LFRicLoopBounds from dynamo0p3.py
arporter
added a commit
that referenced
this issue
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
An issue that is probably suitable for a new PSyclone developer
LFRic
Issue relates to the LFRic domain
Part of the splitting dynamo0p3.py work detailed in #2235
LFRicLoopBounds appears in
domain/lfric/lfric_invoke.py
andtests/domain/lfric/lfric_loop_bounds_test.py
, no name change needed - uses LFRicCollection, so unlikely to have a circular dependencyApproximate order of things that need to be done:
domain/lfric/lfric_loop_bounds.py
, add the license to top (and your name to modifiers!*)dynamo0p3.py
(don't forget documentation util at the bottom!)pylint dynamo0p3.py
, remove unused importspylint domain/lfric/lfric_loop_bounds.py
, dittopycodestyle
the samelfric_loop_bounds.py
todomain/lfric/__init__.py
from psyclone.domain.lfric import LFRicLoopBounds
in the files it is imported in - remove anydisable=import-outside-top-level
that are no longer usedpylint
andpycodestyle
on all files changedpytest
*this is for all files you change, check the year range of the copyright too and update if needed
The text was updated successfully, but these errors were encountered: