Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues with the atlas texture cache #7

Merged
merged 13 commits into from
Sep 8, 2024
Merged

Fix various issues with the atlas texture cache #7

merged 13 commits into from
Sep 8, 2024

Conversation

Steveplays28
Copy link
Member

@Steveplays28 Steveplays28 commented Sep 7, 2024 •
edited
Loading

  • Fix mipmapping issues with atlas textures loaded from cache
  • Fix an occasional native crash when writing NativeImages to JSON
  • Move some Mixin classes into packages
  • Remove unused code
  • Use enabled resource packs' names for the hash
    • Rename the .minecraft/.blinkload/mod_list_hash file to .minecraft/.blinkload/mod_and_enabled_resource_pack_list_hash
  • Filter substrings from the mod/resource pack list instead of prefixes

Fixes #5.

@Steveplays28
refactor: Invalidate the atlas texture cache when reloading resources
dd88081
@Steveplays28
fix: Fix cache recreation when reloading resources
c873676
@Steveplays28
fix: Fix mipmapping issues and crashes
ef9ecb4 
Also moved some Mixin classes into packages and removed unused code.
@Steveplays28
fix: Fix cache directory not being deleted recursively when it's out …
9cd07da 
…of date
@Steveplays28
perf: Write cache data to the cache file asynchronously
b03cf78
@Steveplays28
fix: Fix native crash when writing files
7d76e82 
Also improved logging and rolled back the `NativeImageAdapter`, because saving the images in JSON is faster than creating hundreds of PNG files.
@Steveplays28
fix: Fix crash when a JSON element is an instance of JsonNull or wh…
f35faf1 
…en an exception occurs
@Steveplays28
feat: Use enabled resource packs for the atlas texture cache hash
82793d0
@Steveplays28
refactor: Change hash name prefix filter to a substring filter
223e934
@Steveplays28 Steveplays28 added bug Something isn't working crash Bug that causes a crash enhancement New feature or request labels Sep 7, 2024
@Steveplays28 Steveplays28 self-assigned this Sep 7, 2024
@Steveplays28 Steveplays28 added the waiting for release This issue has been fixed, but the fix hasn't been released yet label Sep 8, 2024
BartolJukica
BartolJukica approved these changes Sep 8, 2024
View reviewed changes
Copy link
Collaborator

@BartolJukica BartolJukica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BartolJukica BartolJukica merged commit f54ca1a into 1.20-1.20.1 Sep 8, 2024
4 checks passed
@BartolJukica BartolJukica deleted the improve-cache-invalidation branch September 8, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartolJukica BartolJukica BartolJukica approved these changes

Assignees

@Steveplays28 Steveplays28

Labels
bug Something isn't working crash Bug that causes a crash enhancement New feature or request waiting for release This issue has been fixed, but the fix hasn't been released yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading atlas textures from cache fails
2 participants
@Steveplays28 @BartolJukica