Simple method forwarding example #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discussion on discourse, I created a simple example where I create a new
Materialtype that is a subtype ofShapeand can then be used to store metadata (like material parameters) without redefining any of the coreGeometryPrimitivesmethods (instead we just "forward" them).Unfortunately, this produces a stack overflow error. Typically, stack overflow errors are caused by recursion. But I'm using the
findfirst()method (not on a recursiveKDtree). So I'm not sure where the recursion would take place. So it's probably something else. Unfortunately there's no stack trace, and my debugger dies.(It would also be good to include all of the important interface functions up front. For example, It's obvious from
src/GeometryPrimitives.jlthatBase.in()needs to be forwarded, but it's not obvious thatbounds()also needs to be forwarded (based on the logic in the newfindfirst()method).(This PR is stacked on top of #39... all of the extra changes here will go away once I can rebase).