Skip to content

Commit

Permalink
Small fix to the pip plot; also revised the last part of the fsusie_i…
Browse files Browse the repository at this point in the history
…ntro vignette.
  • Loading branch information
pcarbo committed Jul 8, 2024
1 parent 99b71e9 commit 4305933
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 20 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Encoding: UTF-8
Type: Package
Package: fsusieR
Version: 0.2.73
Date: 2024-07-05
Version: 0.2.74
Date: 2024-07-08
Title: Sum of Single Functions
Authors@R: person("William R. P.","Denault",role = c("aut","cre"),
email = "[email protected]")
Expand Down
4 changes: 2 additions & 2 deletions R/plot_functions.R
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ plot.susiF <- function(x, ...) {
#'
plot_susiF_pip <- function (obj,
title = "",
point_size = 2,
point_size = 1.25,
pos_SNP,
point_shape,
font_size = 10 ) {
font_size = 10) {
if (missing(pos_SNP)) {
pos_SNP <- 1:length(obj$pip)
}
Expand Down
2 changes: 1 addition & 1 deletion man/fsusie_plots.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 15 additions & 15 deletions vignettes/fsusie_intro.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ You can also access the posterior inclusion probabilities directly
from the fitted object. Similarly, you can specify the plot_susiF
function to display only the PiP plot.

```{r plot-pips, fig.height=2, fig.width=5, eval=FALSE}
```{r plot-pips, fig.height=1.75, fig.width=5}
plot_susiF_pip(fit)
```

Expand Down Expand Up @@ -243,21 +243,21 @@ To visualize the estimated effects, again we can use the
plot_susiF_effect(fit)
```

## A note on the priors available
## Prior on the effects

Note that fSuSiE has two different priors available:
\textit{mixture_normal_per_scale} and \textit{mixture_normal}. The
default value is \textit{mixture_normal_per_scale}, which has slightly
higher performance (power, estimation accuracy) than the
\textit{mixture_normal}. However, \textit{mixture_normal} is up to 40%
faster than the \textit{mixture_normal_per_scale}. You may consider
using this option before performing genome-wide fine mapping.
"mixture_normal_per_scale" and "mixture_normal". The default value is
"mixture_normal_per_scale", which has slightly higher performance
overall (power, estimation accuracy) than "mixture_normal". However,
"mixture_normal" is somewhat faster than the
"mixture_normal_per_scale":

Here is a comparison between their running time

```{r, eval=FALSE}
out1 <- susiF(Y,X,L=3 , prior = 'mixture_normal_per_scale',verbose=FALSE)
out1$runtime
out2 <- susiF(Y,X,L=3 , prior = 'mixture_normal',verbose=FALSE)
out2$runtime
```{r fsusie-priors}
fit1 <- susiF(Y,X,L = 10,prior = "mixture_normal_per_scale")
fit2 <- susiF(Y,X,L = 10,prior = "mixture_normal")
fit1$runtime
fit2$runtime
```

Therefore, for larger data sets you may want to use the
"mixture_normal" prior.

0 comments on commit 4305933

Please sign in to comment.