feat: Added new PasswordStrengthScore method #2599
Conversation
By integrating `zxcvbn` module, it has been added a new method to get the specific password strength score information.
Pull Request Checklist
|
| if err != nil { | ||
| return makeJSONResponse(fmt.Errorf("Error marshalling to json: %v", err)) | ||
| } | ||
| return string(data) |
There was a problem hiding this comment.
Should it not be makeJSONResponse?
same question for function GetPasswordStrengthScore
There was a problem hiding this comment.
Looks good.
due to an issue parsing JSON response in the NIM site since the zxcvbnreturns big int crack time numbers when the password lenght is big and nim json cannot parse the response correctly
I'm not sure if I fully understand this. You mean that in Nim we have issues parsing the response because the Int returned is too big?
If that's the case, we can use the stint library, which is used to parse big numbers.
If we can, having only one function for Strength and Score would be great
Let me try to explain it better.. And I've realised the post link was wrong so I can understand why you cannot understand my comment!! I firstly created the generic I hope it is more clear now and it has sense :) |
|
@noeliaSD Aaaah yes it's much clearer now. I already approved, so here is a thumbs up instead 👍 |
What does the PR do
By integrating
zxcvbnmodule, it has been added a new method to get the specific password strength score information.Closes #5096 together with related
nim-goanddesktopPRs.NOTE: Added specific get score method althought there is already
PasswordStrengthone, that provides the same but extended information, due to an issue parsing JSON response in the NIM site since thezxcvbnreturns big int crack time numbers when the password lenght is big and nim json cannot parse the response correctly. See the following post.