Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blobs #2762

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Fix blobs #2762

merged 8 commits into from
Oct 22, 2024

Conversation

advaita-saha
Copy link
Contributor

Fixes #2751

@advaita-saha advaita-saha marked this pull request as draft October 20, 2024 22:37
@advaita-saha
Copy link
Contributor Author

@jangko do we have blob transactions in the transactions json file used for txpool tests ?

@jangko
Copy link
Contributor

jangko commented Oct 21, 2024

@jangko do we have blob transactions in the transactions json file used for txpool tests ?

no, but you can use blobDataGenerator in hive_integration/nodocker/engine/cancun/blobs.nim to generate blobs.

@advaita-saha advaita-saha marked this pull request as ready for review October 21, 2024 13:48
jangko
jangko reviewed Oct 22, 2024
View reviewed changes
tests/test_txpool2.nim
noisy = defined(debug)
const noisy = defined(debug)

assert loadKzgTrustedSetup().isOk, "Failed to load KZG trusted setup"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

results.expect will do the same job as assert with a cleaner syntax.

nimbus-eth1/nimbus/evm/computation.nim

Lines 347 to 349 in 070f117

c.gasMeter.consumeGas(codeCost,
reason = "Write new contract code").
expect("enough gas since we checked against gasRemaining")

nimbus-eth1/nimbus/evm/tracer/access_list_tracer.nim

Line 54 in 070f117

let address = c.stack.peekAddress().expect("stack is not empty")

@jangko jangko merged commit c9f97e6 into master Oct 22, 2024
10 checks passed
@jangko jangko deleted the fix-blobs branch October 22, 2024 02:07
jangko pushed a commit that referenced this pull request Oct 22, 2024
@advaita-saha @jangko
Fix blobs (#2762)
0153072 
* add blobGasUsed calculation

* enable old tests

* add blob tests in kurtosis

* add blobGasUsed validation

* revert

* introduce blobs in test

* fix: kzg setup

* prevent regression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jangko jangko jangko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

payload with blob : INVALID
2 participants
@advaita-saha @jangko