Prevent SO evaluation to get stuck on multivariate queries. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eicca
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Thanks for this wonderful contribution @MatteoGiomi, I've left a few comments!
MatteoGiomi
force-pushed
the
matteo/feat/timeout-so-queries
branch
from
ef5c4e8
to
f253b62
Compare
MatteoGiomi
force-pushed
the
matteo/feat/timeout-so-queries
branch
from
f253b62
to
6662bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some combinations of datasets and parameters, the
SinglingOutEvaluatorcan take very very long when generating multivariate queries. This PR adds amax_attemptsparameter that can be use to specify the maximum number of query generation attempts that are allowed. By default this new parameter isNone, and have no effect.