[5.x] Throw 404 if taxonomy isn’t assigned to collection #10438
+17
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Taxonomy Routing docs state, that "For each taxonomy assigned to a collection you will also get these routes …", talking about the routes for
Collection Taxonomy Details
andCollection Term Details
pages.However, I've noticed that these routes were also available for taxonomies that haven't been assigned the collection in question. This PR fixes this issue by throwing a
404
if you're visiting a collection taxonomy or collection term route of a taxonomy that hasn't been assigned to the collection in question.A
404
will be thrown if …/{collection-url}/{taxonomy-slug}
and the taxonomy hasn't been assigned to the collection/{collection-url}/{taxonomy slug}/{term-slug}
and the taxonomy hasn't been assigned to the collection