More PatchComponent Changes #5139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified all .tsx within /settings/tasks
Rest of the PatchComponent changes.
WithoutPants
requested changes
Aug 20, 2024
| } | ||
|
|
||
| const LogElement: React.FC<ILogElementProps> = PatchComponent( | ||
| "LogElement", |
There was a problem hiding this comment.
Where a component is not exported, it usually indicates that it's part of a larger component. In these cases, it's ideal to name these as a sub-component of the parent component. In this case, since this is a child component of SettingsLogsPanel, I think this should be SettingsLogsPanel.LogElement. This helps reduce potential duplicate component labels.
|
|
||
| const ScraperTable: React.FC< | ||
| PropsWithChildren<{ | ||
| entityType: string; | ||
| count?: number; | ||
| }> | ||
| > = ({ entityType, count, children }) => { | ||
| > = PatchComponent("ScraperTable", ({ entityType, count, children }) => { |
There was a problem hiding this comment.
As above, I think this should be SettingsScrapingPanel.ScraperTable. I won't mark all of these, but please do a pass and correct the non-exported ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified all .tsx within /settings/tasks