Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(network): add docs for some of the public structs #1925

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

nagmo-starkware
Copy link
Contributor

@nagmo-starkware nagmo-starkware commented Apr 18, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@nagmo-starkware
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nagmo-starkware and the rest of your teammates on Graphite Graphite

@nagmo-starkware nagmo-starkware marked this pull request as ready for review April 18, 2024 13:36
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (5b83ab4) to head (a6c434d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1925   +/-   ##
=======================================
  Coverage   73.95%   73.95%           
=======================================
  Files         127      127           
  Lines       16369    16369           
  Branches    16369    16369           
=======================================
  Hits        12106    12106           
  Misses       2866     2866           
  Partials     1397     1397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagmo-starkware nagmo-starkware added this pull request to the merge queue Apr 21, 2024
Merged via the queue into main with commit 2511b3a Apr 21, 2024
32 checks passed
@nagmo-starkware nagmo-starkware deleted the nevo/network/add_docs branch April 21, 2024 05:24
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants