Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add db table iterator #1235

Merged
merged 1 commit into from
Oct 3, 2023
Merged

feat(storage): add db table iterator #1235

merged 1 commit into from
Oct 3, 2023

Conversation

Yael-Starkware
Copy link
Contributor

@Yael-Starkware Yael-Starkware commented Oct 2, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1235 (b3248cf) into main (f711cec) will decrease coverage by 0.20%.
Report is 3 commits behind head on main.
The diff coverage is 66.52%.

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   72.04%   71.84%   -0.20%     
==========================================
  Files          78       80       +2     
  Lines        7622     7810     +188     
  Branches     7622     7810     +188     
==========================================
+ Hits         5491     5611     +120     
- Misses       1254     1300      +46     
- Partials      877      899      +22     
Files Coverage Δ
crates/papyrus_storage/src/db/mod.rs 83.00% <100.00%> (+0.61%) ⬆️
crates/papyrus_storage/src/lib.rs 59.20% <ø> (ø)
crates/papyrus_storage/src/serializers.rs 84.25% <100.00%> (+0.04%) ⬆️
crates/starknet_client/src/reader/objects/block.rs 87.50% <85.71%> (-0.26%) ⬇️
crates/papyrus_common/src/block_hash.rs 84.74% <89.09%> (+1.56%) ⬆️
crates/papyrus_sync/src/lib.rs 70.40% <72.72%> (+0.63%) ⬆️
crates/papyrus_node/src/main.rs 2.40% <0.00%> (-0.41%) ⬇️
crates/papyrus_sync/src/sources/pending.rs 20.83% <20.83%> (ø)
crates/papyrus_storage/src/mmap_file/mod.rs 67.44% <67.44%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)


crates/papyrus_storage/src/db/mod.rs line 383 at r1 (raw file):

}

/// A wrapper around a cursor that allows iterating over a table.

Iterator for iterating over a DB table.

Copy link
Contributor

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 62bc244 Oct 3, 2023
35 of 36 checks passed
@Yael-Starkware Yael-Starkware deleted the yael/db_iter branch October 3, 2023 07:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants