Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): impl behaviour's send_data #1230

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Oct 1, 2023

  • feat(network): add PeerId to NewInboundSession event
  • feat(network): convert handler event to behaviour event
  • feat(network): impl behaviour's on_connection_handler_event
  • feat(network): impl behaviour's close_session
  • feat(network): impl behaviour's send_data

This change is Reviewable

@ShahakShama ShahakShama changed the base branch from p2p to shahak/network/behaviour_close_session October 1, 2023 15:37
Copy link
Contributor

@nagmo-starkware nagmo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @ShahakShama)


crates/papyrus_network/src/streamed_data_protocol/behaviour.rs line 136 at r1 (raw file):

    ) -> Result<(), SessionIdNotFoundError> {
        self.pending_events.push_back(ToSwarm::NotifyHandler {
            peer_id: *self

same case as last PR.. this line is busy consider braking it down.
although line breaks help a bit

@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_close_session branch from cffbf28 to 6e342ef Compare October 2, 2023 08:40
@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_send_data branch from e3e9c3c to 7e7a206 Compare October 2, 2023 08:41
@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_close_session branch from 6e342ef to df1edf9 Compare October 2, 2023 10:10
@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_send_data branch from 7e7a206 to c5c8a1e Compare October 2, 2023 10:18
Copy link
Contributor

@nagmo-starkware nagmo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_send_data branch from c5c8a1e to 926ad83 Compare October 2, 2023 10:43
Copy link
Contributor

@nagmo-starkware nagmo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_send_data branch from 926ad83 to 0a06d2f Compare October 2, 2023 11:14
Copy link
Contributor

@nagmo-starkware nagmo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@ShahakShama ShahakShama merged commit d412d8b into shahak/network/behaviour_close_session Oct 2, 2023
17 of 18 checks passed
@ShahakShama ShahakShama deleted the shahak/network/behaviour_send_data branch October 2, 2023 12:49
ShahakShama added a commit that referenced this pull request Oct 2, 2023
* feat(network): impl behaviour's close_session

* feat(network): impl behaviour's send_data (#1230)
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants