-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(network): impl behaviour's send_data #1230
feat(network): impl behaviour's send_data #1230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @ShahakShama)
crates/papyrus_network/src/streamed_data_protocol/behaviour.rs
line 136 at r1 (raw file):
) -> Result<(), SessionIdNotFoundError> { self.pending_events.push_back(ToSwarm::NotifyHandler { peer_id: *self
same case as last PR.. this line is busy consider braking it down.
although line breaks help a bit
cffbf28
to
6e342ef
Compare
e3e9c3c
to
7e7a206
Compare
6e342ef
to
df1edf9
Compare
7e7a206
to
c5c8a1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
c5c8a1e
to
926ad83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
926ad83
to
0a06d2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
d412d8b
into
shahak/network/behaviour_close_session
* feat(network): impl behaviour's close_session * feat(network): impl behaviour's send_data (#1230)
This change is