Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): impl behaviour's on_connection_handler_event #1228

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat(network): impl behaviour's on_connection_handler_event #1228

merged 1 commit into from
Oct 2, 2023

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Oct 1, 2023 •
edited by spapinistarkware
Loading

  • feat(network): add PeerId to NewInboundSession event
  • feat(network): convert handler event to behaviour event
  • feat(network): impl behaviour's on_connection_handler_event

This change is Reviewable

@ShahakShama ShahakShama changed the base branch from p2p to shahak/network/event_conversion October 1, 2023 10:47
@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_on_connection_handler_event branch from b1441fb to f7f7edf Compare October 1, 2023 12:37
@ShahakShama ShahakShama force-pushed the shahak/network/event_conversion branch 2 times, most recently from 8832d8c to 546f7e5 Compare October 2, 2023 08:38
nagmo-starkware
nagmo-starkware approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@nagmo-starkware nagmo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@ShahakShama ShahakShama force-pushed the shahak/network/behaviour_on_connection_handler_event branch from f7f7edf to 12c4e0f Compare October 2, 2023 08:39
@ShahakShama ShahakShama merged commit d067cbb into shahak/network/event_conversion Oct 2, 2023
17 of 18 checks passed
@ShahakShama ShahakShama deleted the shahak/network/behaviour_on_connection_handler_event branch October 2, 2023 09:38
ShahakShama added a commit that referenced this pull request Oct 2, 2023
@ShahakShama
feat(network): convert handler event to behaviour event (#1227)
d1588df 
* feat(network): add PeerId to NewInboundSession event

* feat(network): convert handler event to behaviour event

* feat(network): impl behaviour's on_connection_handler_event (#1228)
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nagmo-starkware nagmo-starkware nagmo-starkware approved these changes

@dan-starkware dan-starkware Awaiting requested review from dan-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShahakShama @nagmo-starkware