Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(network): add SessionClosedByRequest event #1221

Merged
merged 1 commit into from
Sep 28, 2023
Merged

feat(network): add SessionClosedByRequest event #1221

merged 1 commit into from
Sep 28, 2023

Conversation

ShahakShama
Copy link
Contributor

@ShahakShama ShahakShama commented Sep 28, 2023 •
edited by spapinistarkware
Loading

This change is Reviewable

nagmo-starkware
nagmo-starkware approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@nagmo-starkware nagmo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@ShahakShama ShahakShama merged commit dd8dac8 into p2p Sep 28, 2023
32 of 34 checks passed
@ShahakShama ShahakShama deleted the shahak/network/closed_by_request_event branch September 28, 2023 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nagmo-starkware nagmo-starkware nagmo-starkware approved these changes

@dan-starkware dan-starkware Awaiting requested review from dan-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShahakShama @nagmo-starkware