Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): add block messages through protobuf (#1116) #1130

Closed
wants to merge 29 commits into from

Conversation

nagmo-starkware
Copy link
Contributor

@nagmo-starkware nagmo-starkware commented Sep 4, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #1130 (4b544e1) into main (f711cec) will increase coverage by 1.94%.
Report is 11 commits behind head on main.
The diff coverage is 62.85%.

❗ Current head 4b544e1 differs from pull request most recent head b9218eb. Consider uploading reports for the commit b9218eb to get more accurate results

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   72.04%   73.98%   +1.94%     
==========================================
  Files          78       81       +3     
  Lines        7622     7034     -588     
  Branches     7622     7034     -588     
==========================================
- Hits         5491     5204     -287     
+ Misses       1254      971     -283     
+ Partials      877      859      -18     
Files Coverage Δ
crates/papyrus_network/src/messages/mod.rs 84.61% <84.61%> (ø)
.../papyrus_network/src/streamed_data_protocol/mod.rs 0.00% <0.00%> (ø)
crates/papyrus_network/src/messages/block.rs 0.00% <0.00%> (ø)
...rus_network/src/streamed_data_protocol/protocol.rs 89.83% <89.83%> (ø)
...us_network/src/streamed_data_protocol/behaviour.rs 63.95% <63.95%> (ø)
...yrus_network/src/streamed_data_protocol/handler.rs 50.00% <50.00%> (ø)

... and 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

github-actions bot commented Nov 5, 2023

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale No activity for quite some time. label Nov 5, 2023
@github-actions github-actions bot closed this Nov 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale No activity for quite some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants