Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move rpc state reader to state reader crate #492

Open
wants to merge 1 commit into
base: pr/Itay-Tsabary-Starkware/tsabary/state_reader_client/53ab0222
Choose a base branch
from

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware commented Jul 16, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.34%. Comparing base (c806208) to head (145b276).

Files Patch % Lines
crates/state_reader/src/errors.rs 0.00% 12 Missing ⚠️
crates/state_reader/src/config.rs 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                         @@
##           pr/Itay-Tsabary-Starkware/tsabary/state_reader_client/53ab0222     #492      +/-   ##
==================================================================================================
- Coverage                                                           83.38%   83.34%   -0.05%     
==================================================================================================
  Files                                                                  37       39       +2     
  Lines                                                                1776     1777       +1     
  Branches                                                             1776     1777       +1     
==================================================================================================
  Hits                                                                 1481     1481              
- Misses                                                                218      219       +1     
  Partials                                                               77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/state_reader_client/c590a350 branch 3 times, most recently from 6570777 to 760c94c Compare July 16, 2024 17:44
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the pr/Itay-Tsabary-Starkware/tsabary/state_reader_client/c590a350 branch from 760c94c to 145b276 Compare July 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants