Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: download directory #324

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

aner-starkware
Copy link
Contributor

@aner-starkware aner-starkware commented Jul 23, 2024

This change is Reviewable

@aner-starkware aner-starkware self-assigned this Jul 23, 2024
@aner-starkware aner-starkware marked this pull request as ready for review July 23, 2024 13:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (2e85680) to head (7af5cfc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   70.03%   70.03%           
=======================================
  Files          38       38           
  Lines        2109     2109           
  Branches     2109     2109           
=======================================
  Hits         1477     1477           
  Misses        562      562           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @nimrod-starkware)

Copy link
Contributor

@TzahiTaub TzahiTaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @nimrod-starkware)

@aner-starkware aner-starkware added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 79dcb89 Jul 24, 2024
25 checks passed
@aner-starkware aner-starkware deleted the aner/refactor_download_directory branch July 24, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants