refactor: use mock test utils in update skeleton tests

[AvivYossef-starkware]

This change is 

[AvivYossef-starkware]

• refactor: use mock test utils in update skeleton tests #320 👈
• refactor: use mock test utils in filled tree test #319
• refactor: use mock leaf in create tree test #316
• build: impl mock test utils #314
• refactor: remove dependency between storage and starknet prefix #308
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @AvivYossef-starkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (2e85680) to head (172dc30).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   70.03%   70.03%           
=======================================
  Files          38       38           
  Lines        2109     2109           
  Branches     2109     2109           
=======================================
  Hits         1477     1477           
  Misses        562      562           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware)

---

crates/committer/src/patricia_merkle_tree/internal_test_utils.rs line 29 at r2 (raw file):

use rstest::{fixture, rstest};

use crate::patricia_merkle_tree::filled_tree::tree::FilledTreeImpl;

if you move this above the use ethnum::U256 will it be sorted better...?

Code quote:

use crate::patricia_merkle_tree::filled_tree::tree::FilledTreeImpl;

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/create_tree_helper_test.rs line 503 at r2 (raw file):

#[tokio::test]
async fn test_update_non_modified_storage_tree(#[case] root_hash: HashOutput) {
    use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig;

move to top

Code quote:

use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree_test.rs line 148 at r2 (raw file):

#[case::non_empty_modifications(HashMap::from([(NodeIndex::FIRST_LEAF + NodeIndex::from(7), MockLeaf::default())]))]
fn test_updated_empty_tree(#[case] modifications: LeafModifications<MockLeaf>) {
    use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig;

move to top

Code quote:

use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig;

[AvivYossef-starkware]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/committer/src/patricia_merkle_tree/internal_test_utils.rs line 29 at r2 (raw file):

Previously, dorimedini-starkware wrote…

if you move this above the use ethnum::U256 will it be sorted better...?

Yes.

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/create_tree_helper_test.rs line 503 at r2 (raw file):

Previously, dorimedini-starkware wrote…

move to top

Done.

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/tree_test.rs line 148 at r2 (raw file):

Previously, dorimedini-starkware wrote…

move to top

Done.

[dorimedini-starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/create_tree_helper_test.rs line 503 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

Done.

nope

[AvivYossef-starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/committer/src/patricia_merkle_tree/updated_skeleton_tree/create_tree_helper_test.rs line 503 at r2 (raw file):

Previously, dorimedini-starkware wrote…

nope

Sorry

[dorimedini-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)