Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for call contract error catching #777

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Add warning for call contract error catching #777

merged 2 commits into from
Aug 29, 2023

Conversation

JameStark
Copy link
Contributor

@JameStark JameStark commented Aug 29, 2023

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

* Add warning for lack of error catch on call_contract syscall

* Update system-calls-cairo1.adoc

* Update system-calls-cairo1.adoc
@JameStark JameStark merged commit 7f1f00f into master Aug 29, 2023
3 checks passed
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-777/documentation/ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant