-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update transaction-life-cycle.adoc #764
Conversation
In step 2 we need to write that there are to validation steps, one occurs in the gateways and again in the sequencer. I added this comment: // There is a step missing that the sequencer runs the validation again before _execute_
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ . |
...ules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc
Outdated
Show resolved
Hide resolved
…twork_Architecture/Blocks/transaction-life-cycle.adoc
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ . |
...ules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc
Show resolved
Hide resolved
…twork_Architecture/Blocks/transaction-life-cycle.adoc
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @EvyatarO, @JameStark, and @stoobie)
components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc
line 17 at r1 (raw file):
Previously, stoobie (Steve Goodman) wrote…
// There is a step missing that the sequencer runs the validation again before _execute_
Done.
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ . |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ . |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ . |
* Add block time to limits and triggers (#770) * Add block time to limits and triggers * Remove max * docs: Add special address section (#726) * Add special address section * Update starknet-state.adoc * Update starknet-state.adoc * Update special addresses based on Evyatar feedback * Update starknet-state.adoc * Reword 0x0 address * Update starknet-state.adoc * Update starknet-state.adoc * Update starknet-state.adoc * Feedback actioned * Update transaction-life-cycle.adoc (#764) * Update transaction-life-cycle.adoc In step 2 we need to write that there are to validation steps, one occurs in the gateways and again in the sequencer. I added this comment: // There is a step missing that the sequencer runs the validation again before _execute_ * Update components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc * Update components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc * Update transaction-life-cycle.adoc --------- Co-authored-by: Steve Goodman <[email protected]> Co-authored-by: JameStark <[email protected]> Co-authored-by: JameStark <[email protected]> --------- Co-authored-by: adishildan <[email protected]> Co-authored-by: Steve Goodman <[email protected]>
In step 2 we need to write that there are to validation steps, one occurs in the gateways and again in the sequencer. I added this comment: // There is a step missing that the sequencer runs the validation again before execute
This change is