Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transaction-life-cycle.adoc #764

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Update transaction-life-cycle.adoc #764

merged 6 commits into from
Aug 24, 2023

Conversation

adishildan
Copy link
Collaborator

@adishildan adishildan commented Aug 22, 2023

In step 2 we need to write that there are to validation steps, one occurs in the gateways and again in the sequencer. I added this comment: // There is a step missing that the sequencer runs the validation again before execute


This change is Reviewable

In step 2 we need to write that there are to validation steps, one occurs in the gateways and again in the sequencer. I added this comment: 
// There is a step missing that the sequencer runs the validation again before _execute_
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ .

…twork_Architecture/Blocks/transaction-life-cycle.adoc
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ .

…twork_Architecture/Blocks/transaction-life-cycle.adoc
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ .

Copy link
Collaborator Author

@adishildan adishildan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @EvyatarO, @JameStark, and @stoobie)


components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc line 17 at r1 (raw file):

Previously, stoobie (Steve Goodman) wrote…
// There is a step missing that the sequencer runs the validation again before _execute_

Done.

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-764/documentation/ .

@JameStark JameStark merged commit 94adb11 into dev Aug 24, 2023
2 checks passed
@JameStark JameStark deleted the adishildan-patch-1 branch August 24, 2023 11:16
JameStark added a commit that referenced this pull request Aug 24, 2023
* Add block time to limits and triggers (#770)

* Add block time to limits and triggers

* Remove max

* docs: Add special address section (#726)

* Add special address section

* Update starknet-state.adoc

* Update starknet-state.adoc

* Update special addresses based on Evyatar feedback

* Update starknet-state.adoc

* Reword 0x0 address

* Update starknet-state.adoc

* Update starknet-state.adoc

* Update starknet-state.adoc

* Feedback actioned

* Update transaction-life-cycle.adoc (#764)

* Update transaction-life-cycle.adoc

In step 2 we need to write that there are to validation steps, one occurs in the gateways and again in the sequencer. I added this comment: 
// There is a step missing that the sequencer runs the validation again before _execute_

* Update components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc

* Update components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/Blocks/transaction-life-cycle.adoc

* Update transaction-life-cycle.adoc

---------

Co-authored-by: Steve Goodman <[email protected]>
Co-authored-by: JameStark <[email protected]>
Co-authored-by: JameStark <[email protected]>

---------

Co-authored-by: adishildan <[email protected]>
Co-authored-by: Steve Goodman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants