Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Edited Contract migration guide #674

Closed
wants to merge 13 commits into from

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented Jul 12, 2023

Description of the Changes

@JameStark
I edited components/Starknet/modules/architecture_and_concepts/pages/Cairo_on_Starknet/contract-syntax.adoc.

This is the only file edited. I just tried to resolve conflicts in the rest of the files so I could complete rebase. But you should resolve these conflicts yourself.

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-674/documentation/architecture_and_concepts/Cairo_on_Starknet/contract-syntax/

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@stoobie stoobie requested a review from JameStark July 12, 2023 12:49
@stoobie stoobie changed the title Steve/contract syntax update docs: Edited Contract migration guide Jul 12, 2023
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

3 similar comments
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

@stoobie stoobie force-pushed the steve/contract_syntax_update branch from 857d6e8 to 43fa220 Compare July 20, 2023 13:10
@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

@github-actions
Copy link

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-674/documentation/ .

@JameStark JameStark marked this pull request as draft September 11, 2023 10:31
@JameStark
Copy link
Contributor

Cherry picked changes into new directory structure (that happened after this PR was opened)

@JameStark JameStark closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants