Add option to return query results w/ order matching SELECT bindings #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyfreeman
commented
Aug 31, 2023
| @@ -122,7 +123,7 @@ | |||
| (let [namespaces (into {} | |||
| (map (fn [^Namespace ns] [(.prefix ns) (.iri ns)])) | |||
| (iterator-seq (.. results namespaces iterator)))] | |||
| (with-meta (vector-map-results valfn results) {:namespaces namespaces}))) | |||
| (vary-meta (vector-map-results valfn results) assoc :namespaces namespaces))) | |||
There was a problem hiding this comment.
with-meta sets the metadata, overriding any previous metadata that may or may not have been present. vary-meta updates existing metadata, and has the same signature as update. We almost always want to accumulate metadata, never override it with new values.
dannyfreeman
force-pushed
the
ordered-query-results
branch
from
55d14ce
to
d592176
Compare
dannyfreeman
commented
Aug 31, 2023
| @@ -98,11 +96,12 @@ | |||
|
|
|||
| (defn key-map-results | |||
| "Converts a Iteration of bindings into a seq of keymaps." | |||
| [^IFn keyfn ^IFn valfn ^CloseableIterator results] | |||
| [^IFn keyfn ^IFn valfn ^SelectQueryResult results] | |||
There was a problem hiding this comment.
Changing this to a more specific interface, which implements CLoseableIterator. See https://docs.stardog.com/javadoc/snarl/com/stardog/stark/query/SelectQueryResult.html
Necessary to avoid reflecting when calling the variables method.
dannyfreeman
requested review from
cullan,
mikesoren,
gcoluni and
AnastasiaRaffucci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.