Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RockyLinux 9 #164

Merged
merged 15 commits into from
Feb 20, 2024
Merged

Support RockyLinux 9 #164

merged 15 commits into from
Feb 20, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Oct 25, 2023 •
edited
Loading

Add support for RockyLinux 9.

Bumps CI images to RL8.9 and RL9.3

Also changes ProctrackType to sensible default for Linux

@sjpb sjpb requested a review from a team as a code owner October 25, 2023 15:04
@sjpb sjpb marked this pull request as draft October 25, 2023 15:04
@sjpb sjpb mentioned this pull request Oct 25, 2023
Closed
@sjpb sjpb mentioned this pull request Jan 24, 2024
Merged
@sjpb sjpb force-pushed the rl9 branch 4 times, most recently from 8aa55a2 to e7f9d08 Compare February 6, 2024 11:01
@sjpb sjpb changed the title DO NOT MERGE: PoC for RockyLinux 9 PoC for RockyLinux 9 Feb 6, 2024
@sjpb sjpb changed the title PoC for RockyLinux 9 Support RockyLinux 9 Feb 6, 2024
@sjpb sjpb marked this pull request as ready for review February 6, 2024 13:22
@sjpb sjpb mentioned this pull request Feb 16, 2024
Draft
m-bull
m-bull reviewed Feb 20, 2024
View reviewed changes
tasks/runtime.yml Outdated Show resolved Hide resolved
JohnGarbutt
JohnGarbutt reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks close, but I think I need to understand cgroups more :/

tasks/install.yml Show resolved Hide resolved
tasks/runtime.yml Outdated Show resolved Hide resolved
templates/slurm.conf.j2 Show resolved Hide resolved
JohnGarbutt
JohnGarbutt previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this looks good, assuming CI is happy with this version.

@sjpb sjpb enabled auto-merge (squash) February 20, 2024 16:21
@sjpb sjpb merged commit 7f547d0 into master Feb 20, 2024
33 checks passed
@sjpb sjpb deleted the rl9 branch February 20, 2024 16:22
@sjpb sjpb restored the rl9 branch March 8, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bull m-bull m-bull left review comments

@JohnGarbutt JohnGarbutt JohnGarbutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjpb @JohnGarbutt @m-bull