Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gitea support #126

Closed
wants to merge 1 commit into from
Closed

add gitea support #126

wants to merge 1 commit into from

Conversation

port19x
Copy link

@port19x port19x commented Jul 12, 2024

closes #117

@port19x
Copy link
Author

port19x commented Jul 12, 2024

my very broad regex will probably break some customizations¹
This is because alist-get fetches the first match and custom domains will likely match my regex before reaching the appended alist entry

@sshaw
Copy link
Owner

sshaw commented Jul 21, 2024

Hi, thanks for the PR.

my very broad regex will probably break some customizations¹

Is the use of Gitea so widespread that it is worth breaking these customizations?

Since Gitea is self-hosted and has all sorts of URLs is it even needed in list this library when one can call add-to-listas needed using the appropriate config-specific URL?

@port19x
Copy link
Author

port19x commented Jul 21, 2024

It sees a fair amount of use by corporates and self-hosting types.
A way to integrate it that does not break these customizations would be to modify the alist-get calls.
Adding the right appropiate backends as the third argument would set it as default, which gives further opportunity to downside the alists, especially since homepage is fairly uniform.

@sshaw
Copy link
Owner

sshaw commented Jul 21, 2024

A way to integrate it that does not break these customizations would be to modify the alist-get calls.
Adding the right appropiate backends as the third argument would set it as default, which gives further opportunity to
downside the alists, especially since homepage is fairly uniform.

This seems like unnecessary work given the alternative:

(eval-after-load 'git-link
 '(progn
   (add-to-list 'git-link-remote-alist
     '("your-custom-gitea-url" git-link-codeburg))

Maybe a defalias is needed so that one can say git-link-gitea instead?

This situation is similar to Cgit which we currently support via a custom function but it is not added to git-link-remote-alist etc... because there is no definitive URL like GitLab, etc...

@sshaw
Copy link
Owner

sshaw commented Jul 21, 2024

This seems like unnecessary work given the alternative:
(eval-after-load 'git-link
'(progn
(add-to-list 'git-link-remote-alist
...

Now admittedly having to add to 3 lists is not ideal and should change. I think #115 has a proposed fix for this

@port19x
Copy link
Author

port19x commented Jul 22, 2024

Well then, given the workaround, I'll close the PR.
Anyone curious enough to check the issue tracker for support will find what backends to set, so that's fine.

@port19x port19x closed this Jul 22, 2024
@sshaw
Copy link
Owner

sshaw commented Jul 23, 2024

Updated docs with info on how to enable Gitea support and added git-link-*gitea functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support 'Gitea' 's (and its fokr : Forgejo ?) server ?
2 participants