Add childquestions backend integration and refactor datainput datastructure #138

MaHaWo · 2024-10-29T15:30:09Z

No description provided.

commit 1ed8ef3 Merge: 83b2e59 7679af8 Author: Harald Mack <[email protected]> Date: Tue Oct 29 15:53:23 2024 +0100 Merge pull request #130 from ssciwr/fix-userquestions-in-admin Integrate admin interface into user landing page commit 7679af8 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Tue Oct 29 13:31:01 2024 +0000 update openapi.json & openapi-ts client, run pnpm format commit c28089c Merge: 03f911a 5b737fc Author: Harald Mack <[email protected]> Date: Tue Oct 29 14:30:15 2024 +0100 Merge branch 'fix-userquestions-in-admin' of github.com:ssciwr/mondey into fix-userquestions-in-admin commit 03f911a Author: Harald Mack <[email protected]> Date: Tue Oct 29 14:30:11 2024 +0100 add autocomplete to formdata commit 5b737fc Author: Harald Mack <[email protected]> Date: Tue Oct 29 14:29:50 2024 +0100 Update mondey_backend/src/mondey_backend/models/questions.py Co-authored-by: Liam Keegan <[email protected]> commit b7fe5e8 Author: Harald Mack <[email protected]> Date: Tue Oct 29 14:22:25 2024 +0100 Update mondey_backend/src/mondey_backend/routers/admin.py Co-authored-by: Liam Keegan <[email protected]> commit a5892fe Author: Harald Mack <[email protected]> Date: Tue Oct 29 14:22:07 2024 +0100 Update frontend/src/lib/components/Admin/EditUserQuestionModal.svelte use localization in question modal Co-authored-by: Liam Keegan <[email protected]> commit 57dfce2 Author: Harald Mack <[email protected]> Date: Tue Oct 29 14:11:44 2024 +0100 remove debug logout commit 0a6b213 Author: Harald Mack <[email protected]> Date: Tue Oct 29 14:09:19 2024 +0100 fix error in loop commit fb7ba48 Author: Harald Mack <[email protected]> Date: Mon Oct 28 17:00:24 2024 +0100 update lock file commit e9e27d2 Author: Harald Mack <[email protected]> Date: Mon Oct 28 16:58:27 2024 +0100 fix conflict commit c0cb20a Author: Harald Mack <[email protected]> Date: Mon Oct 28 16:53:55 2024 +0100 generate code anew commit 1230ead Merge: 3418a85 83b2e59 Author: Harald Mack <[email protected]> Date: Mon Oct 28 16:53:15 2024 +0100 Merge branch 'main' into fix-userquestions-in-admin commit 3418a85 Author: Harald Mack <[email protected]> Date: Mon Oct 28 16:44:10 2024 +0100 remove researchpage commit 687a573 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Mon Oct 28 15:34:59 2024 +0000 update openapi.json & openapi-ts client, run pnpm format commit f11d80d Author: Harald Mack <[email protected]> Date: Mon Oct 28 16:28:55 2024 +0100 remove comment commit 52c8d61 Author: Harald Mack <[email protected]> Date: Mon Oct 28 16:28:16 2024 +0100 remove comments commit 1d44371 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Mon Oct 28 15:02:16 2024 +0000 update openapi.json & openapi-ts client, run pnpm format commit 36ddf78 Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:41:15 2024 +0100 adjust language label commit df5667c Merge: 66b6e45 5fac037 Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:27:35 2024 +0100 Merge branch 'main' into fix-userquestions-in-admin commit 66b6e45 Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:14:12 2024 +0100 remove langStore commit 43f3f5c Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:11:18 2024 +0100 remove langstore commit 732a9c9 Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:09:19 2024 +0100 add translations from main commit c125a48 Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:08:43 2024 +0100 remove languages commit 2fb1c6a Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:04:02 2024 +0100 add localechooser from main commit 24ca1f5 Author: Harald Mack <[email protected]> Date: Mon Oct 28 15:02:39 2024 +0100 add master i18n commit 2c321ec Author: Harald Mack <[email protected]> Date: Mon Oct 28 14:40:46 2024 +0100 fix python tests commit 8295bb2 Author: Harald Mack <[email protected]> Date: Mon Oct 28 14:34:08 2024 +0100 fix userProfile commit f3bb815 Author: Harald Mack <[email protected]> Date: Mon Oct 28 14:13:41 2024 +0100 fix language indexing problem commit 96e2215 Author: Harald Mack <[email protected]> Date: Mon Oct 28 13:46:51 2024 +0100 fix bug in data reading, work on fixing languages commit e32011c Author: Harald Mack <[email protected]> Date: Mon Oct 28 07:35:03 2024 +0100 make datainput simpler commit b99aa08 Author: Harald Mack <[email protected]> Date: Sun Oct 27 22:02:47 2024 +0100 update to svelte 5, use runes mode for datainput commit 2a2f018 Author: Harald Mack <[email protected]> Date: Fri Oct 25 16:56:11 2024 +0200 work on simplifying datastructure commit b424001 Author: Harald Mack <[email protected]> Date: Fri Oct 25 16:19:20 2024 +0200 add fields commit 11965f0 Author: Harald Mack <[email protected]> Date: Fri Oct 25 16:02:58 2024 +0200 work on integrating necessary datastructure everywhere commit d16f637 Author: Harald Mack <[email protected]> Date: Fri Oct 25 11:43:36 2024 +0200 fix json creation for userquestion commit 3c8a66b Author: Harald Mack <[email protected]> Date: Fri Oct 25 11:34:26 2024 +0200 correct language indexing commit 9499dae Author: Harald Mack <[email protected]> Date: Thu Oct 24 21:11:16 2024 +0200 start fising lang_id issue commit 13abba3 Author: Harald Mack <[email protected]> Date: Thu Oct 24 20:30:20 2024 +0200 fix error commit 7a744dd Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Thu Oct 24 13:57:52 2024 +0000 update openapi.json & openapi-ts client, run pnpm format commit bfb39eb Author: Harald Mack <[email protected]> Date: Thu Oct 24 13:34:15 2024 +0200 work on making editing of questions usable commit 4025b92 Author: Harald Mack <[email protected]> Date: Thu Oct 24 11:18:53 2024 +0200 add elements for logged out user, delete separate verify component commit 6722542 Author: Harald Mack <[email protected]> Date: Thu Oct 24 11:11:32 2024 +0200 include admin page into userlandingpage, add admin component instead of route,

for more information, see https://pre-commit.ci

codecov-commenter · 2024-10-29T15:37:35Z

Codecov Report

Attention: Patch coverage is 25.60976% with 366 lines in your changes missing coverage. Please review.

Project coverage is 28.46%. Comparing base (06f1284) to head (ee61263).

Files with missing lines	Patch %	Lines
...ontend/src/lib/components/ChildrenDataInput.svelte	0.00%	138 Missing and 1 partial ⚠️
frontend/src/lib/components/ChildrenGallery.svelte	0.00%	78 Missing and 1 partial ⚠️
frontend/src/lib/components/Admin/Questions.svelte	0.00%	61 Missing and 1 partial ⚠️
.../src/lib/components/Admin/EditQuestionModal.svelte	0.00%	37 Missing ⚠️
.../src/lib/components/DataDisplay/CardDisplay.svelte	0.00%	14 Missing and 1 partial ⚠️
frontend/src/lib/admin.svelte.ts	0.00%	7 Missing ⚠️
frontend/src/lib/components/AdminPage.svelte	0.00%	7 Missing ⚠️
...backend/src/mondey_backend/databases/milestones.py	25.00%	6 Missing ⚠️
...ntend/src/lib/components/Admin/InputPreview.svelte	0.00%	3 Missing ⚠️
...ntend/src/lib/components/Admin/DeleteButton.svelte	0.00%	2 Missing ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   26.83%   28.46%   +1.63%     
==========================================
  Files          93       91       -2     
  Lines        3455     3239     -216     
  Branches      122       88      -34     
==========================================
- Hits          927      922       -5     
+ Misses       2461     2251     -210     
+ Partials       67       66       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…sciwr/mondey into add-childquestions_backend-integration

* add changes from #138 * include review corrections

…ey into add-childrenquestion-backend

…ackend-integration

sonarcloud · 2024-11-06T16:03:03Z

Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

MaHaWo and others added 17 commits October 29, 2024 08:49

add childanswers and base answer model

9f71832

add child question models

4e0311d

add question admin endpoints

6c29ad0

make current tests work again

9c226d5

adjust imports, add test skeleton

13e8ea9

add dummy questions to test fixtures

ebf850f

start working on backend tests

c001d85

work more on backend tests and model inheritance

2866ab9

fix errors in test data

a5cd5a1

try to get sqlmodel inheritnace to work

e8772fd

get rid of inheritance in question models for now

608dc8c

finish user question tests

1dbd66b

finish python test draft

344baca

Merge branch 'main' into add-childquestions_backend-integration

1ea0183

[pre-commit.ci] auto fixes from pre-commit.com hooks

36edc35

for more information, see https://pre-commit.ci

update openapi.json & openapi-ts client, run pnpm format

1c9ded1

MaHaWo and others added 12 commits October 29, 2024 17:02

refactor away DataInput from user registry and login

f48067a

Merge branch 'add-childquestions_backend-integration' of github.com:s…

e55df55

…sciwr/mondey into add-childquestions_backend-integration

update openapi.json & openapi-ts client, run pnpm format

7cb32f3

Merge branch 'main' into add-childquestions_backend-integration

d4334ce

update openapi.json & openapi-ts client

28432c6

fix mistake in register submit function

09c29c0

rework UserDataInput to work with backend datastructure

e335991

Merge branch 'add-childquestions_backend-integration' of github.com:s…

d444682

…sciwr/mondey into add-childquestions_backend-integration

add childquestion support to admin interface

692d6e9

refactor childrenregistration

fa27752

fix error in question kind prop

e1d5b39

fix childquestion interaction

4b537cb

MaHaWo added 5 commits November 6, 2024 09:13

use childname as heading

0a9cfd1

fix error when there is already an image for a child

d322d22

simplify setup in overview

f161695

remove superfluous breadcrumbs

1b4296c

undo some renaming to reduce changes

7c6d181

MaHaWo added a commit that referenced this pull request Nov 6, 2024

add changes from #138

8b764ed

MaHaWo and others added 5 commits November 6, 2024 11:01

Merge branch 'main' into add-childquestions_backend-integration

1464918

ajust existing testes

c9cdebf

update openapi.json & openapi-ts client

4dd8b69

work on reducing code duplication

a4ff972

Merge branch 'add-childquestions_backend-integration' of github.com:s…

8e0a0d8

…sciwr/mondey into add-childquestions_backend-integration

MaHaWo added a commit that referenced this pull request Nov 6, 2024

Refactor userland pages (#144)

06f1284

* add changes from #138 * include review corrections

MaHaWo and others added 17 commits November 6, 2024 11:40

Merge branch 'main' into add-childquestions_backend-integration

97b0072

make default questions uneditable

59f7c61

remove some output, refactor tests to reduce repetition

bdaa4e7

rename children datainput, add delete button for children

aafcaa6

add child questions backend code from pr 138

bdb291f

update openapi.json & openapi-ts client

4312006

add get_child and tests

fe73ea3

update openapi.json & openapi-ts client

c9f261f

add tests

92e4d62

Merge branch 'add-childrenquestion-backend' of github.com:ssciwr/mond…

6bb422d

…ey into add-childrenquestion-backend

start unifying data models for questions, answers

3eebee9

unify class hierarchy of question, answer models

b73dd50

update openapi.json & openapi-ts client

2fb4aa7

Merge branch 'add-childrenquestion-backend' into add-childquestions_b…

ef8abed

…ackend-integration

remove remark from child

ba1e9f7

work on making child elements read-only

b066c5a

update openapi.json & openapi-ts client

ee61263

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add childquestions backend integration and refactor datainput datastructure #138

Add childquestions backend integration and refactor datainput datastructure #138

MaHaWo commented Oct 29, 2024

codecov-commenter commented Oct 29, 2024 •

edited

Loading

sonarcloud bot commented Nov 6, 2024

Add childquestions backend integration and refactor datainput datastructure #138

Are you sure you want to change the base?

Add childquestions backend integration and refactor datainput datastructure #138

Conversation

MaHaWo commented Oct 29, 2024

codecov-commenter commented Oct 29, 2024 • edited Loading

Codecov Report

sonarcloud bot commented Nov 6, 2024

Quality Gate failed

codecov-commenter commented Oct 29, 2024 •

edited

Loading