Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 90s timeout for each convert in CI and retry on timeout, resolves #102 #103

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add 90s timeout for each convert in CI and retry on timeout, resolves #102 #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ jobs:
for filename in $(ls lunchtime*/*.ipynb)
do
if [ "$filename" != "lunchtime1/lunchtime1.ipynb" ]; then
python -m jupyter nbconvert $filename --to slides --execute --ExecutePreprocessor.kernel_name=python
# if conversion takes more than 90s, kill it and try again
# workaround for ipywidgets conversion occasionally hanging
until timeout 90s python -m jupyter nbconvert $filename --to slides --execute --ExecutePreprocessor.kernel_name=python; do sleep 1; done
fi
done
- run: mv README.md lunchtime* dist/.
Expand Down
2 changes: 1 addition & 1 deletion lunchtime8/lunchtime8.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.10.4"
"version": "3.11.0"
}
},
"nbformat": 4,
Expand Down