Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is by far the smallest (read clean) cmake quickstart I have seen. At the risk of adding bloat I made a change so that vcpgk can be used instead of git submodules. To do that I did break
use_submodules
and changed it toexternals
with values ofsubmodules
,vcpkg
, andnone
. I do not like the name for externals, but its a draft. My big concern is that I was unable to get some of the tests to pass on my system dispite manually touchtesting working. I will argue that untested code is implicitly broken code ;) I am not interested in wasting your time, so if you are not interested in this PR I can continue on my own, since it works for my specific needs. If you are interested and could offer a little guidence on why its failing that would be awesome. Thanks for you awesome cookie cutter!