Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] add vcpkg support #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[draft] add vcpkg support #80

wants to merge 1 commit into from

Conversation

geiseri
Copy link

@geiseri geiseri commented May 8, 2022

This is by far the smallest (read clean) cmake quickstart I have seen. At the risk of adding bloat I made a change so that vcpgk can be used instead of git submodules. To do that I did break use_submodules and changed it to externals with values of submodules, vcpkg, and none. I do not like the name for externals, but its a draft. My big concern is that I was unable to get some of the tests to pass on my system dispite manually touchtesting working. I will argue that untested code is implicitly broken code ;) I am not interested in wasting your time, so if you are not interested in this PR I can continue on my own, since it works for my specific needs. If you are interested and could offer a little guidence on why its failing that would be awesome. Thanks for you awesome cookie cutter!

@geiseri
Copy link
Author

geiseri commented May 9, 2022

Hrm. I have vcpkg installed here, so those tests fail on CI. I am not sure if there is a way to cache the binaries for that though, since that could blow up the CI server rebuilding the packages.

@lkeegan
Copy link
Member

lkeegan commented May 9, 2022

@geiseri thank you for this contribution! I haven't had time to look into this properly yet, but maybe adding https://github.com/marketplace/actions/run-vcpkg to the CI jobs would be the way to get the CI to work? (it also caches the binaries)

@dokempf
Copy link
Member

dokempf commented May 13, 2022

I also like the contribution in general and in particular the refactoring towards a more versatile externals parameter. Given that I have no experience with vcpkg, I struggle to fix the testing issues myself however. @geiseri Are purely local tests (run: pytest -m local) passing on your machine? How does the test suite learn where your vcpkg installation is located? Through an env variable VCPKG_ROOT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants