-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 8/9 #58
base: master
Are you sure you want to change the base?
Laravel 8/9 #58
Conversation
Not yet ready |
Confirmed functional. Misread configuration |
Implemented and confirmed to work with L8.6.0. Thanks @bryanrscott |
Up and running in Laravel 8. Thanks @bryanrscott |
README.md
Outdated
@@ -10,6 +10,7 @@ An easy way to send emails with stack trace whenever an exception occurs on the | |||
|
|||
#### For Laravel <= 5.2, please use the [v1 branch](https://github.com/squareboat/sneaker/tree/v1)! | |||
#### For Laravel 5.2 < version <= 6.x, please use the [v5 branch](https://github.com/squareboat/sneaker/tree/v5)! | |||
#### For Laravel 6.x < version <= 8.x, please use the [v7 branch](https://github.com/squareboat/sneaker/tree/v7)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is a bit confusing because of the .x at the start.
I recommend changing it into "For Laravel 7.0 <= version <= 8.x" 😊
And while you're at it, I recommend also changing that second line into "For Laravel 5.3 <= version ..." then...
Less brain cells wasted for developers trying to figure out which branch they need 😊
Clarity recommendations from @JorisDebonnet
@JorisDebonnet Agree and have updated README as suggested |
Add user details to email message
Okay, uh, but it's not 100% as I meant now 😄
Alternatively, 'plain English' could be even easier to read:
Or did I misunderstand, and does Laravel 7 require a separate branch from Laravel 8+? Then I guess the last line would need to say "for Laravel 7.x, please use ..." |
version texts
Yes Laravel 8 would need a seperate branch. |
Hopefully Laravel support for version 8 can be added soon. |
For what it's worth, here's how to use bryanrscott's fork in your own project (that's what I'm doing at the moment) in order to use Sneaker with Laravel 8:
{
"require": {
"squareboat/sneaker": "dev-master"
},
"repositories": [ { "type": "vcs", "url": "https://github.com/bryanrscott/sneaker" } ],
} |
Hi, I just ported my application to Laravel 8 and Sneaker does not seem to work. I have run into this same issue when porting to Laravel 6 and 7, and it was due to the composer version (I had to downgrade composer to 1.10). But now this happens both with composer 1 and 2. This is the message at the end of composer install:
Do ypu have a workaround for this? |
@michaelheumann I would recommend |
@bryanrscott Thanks for keeping this nice package up to date! |
Curious if this project has stalled or if it's possible to install in Laravel 8, or even better, Laravel 9? |
@ eugenevdm the forked version supports Laravel 9 |
1 similar comment
@ eugenevdm the forked version supports Laravel 9 |
Suggested updates for laravel 8. I am suggesting a new branch as laravel 8 upgrades to symphony 5.
Includes edits by @npostman
Welcome any additional suggestions.