Introduce Modifiable interface to standardize modifiers API #2005
+118
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
force-pushed
the
egor.241015.modifiable
branch
from
00efbf6
to
7e88361
Compare
Egorand
changed the title
JakeWharton
reviewed
Oct 15, 2024
Comment on lines
-329
to
-335
| public fun addModifiers(vararg modifiers: KModifier): Builder = apply { | ||
| this.modifiers += modifiers | ||
| } | ||
|
|
||
| public fun addModifiers(modifiers: Iterable<KModifier>): Builder = apply { | ||
| this.modifiers += modifiers | ||
| } |
There was a problem hiding this comment.
These need to be retained for binary compatibility, such as with addAnnotation below. And in other specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #973.
docs/changelog.mdhas been updated if applicable.be added to the changelog.