Reopen addImport with backward compatible addImports #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please explain what the motivation for this change is? |
|
@Egorand you may look at this PR conversation for more info |
|
Not convinced that these changes are backwards compatible, CI should catch it - let's wait for the results. Also, can you please provide a more descriptive PR title that explains what the change does and why? |
|
Hey @InsanusMokrassar, looks like the code doesn't compile - would you be able to fix it? |
|
Of course. Sorry for the delay, usually I am very busy, but I plan to fix it as soon as possible. Thanks for waiting :) |
|
Thanks & no pressure - just wanted to check if you're still planning to update the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API that require to use at least one name in imports in case of variadic syntax usage. The old behaviour have thrown an exception in runtime, but that one will not allow to use variadic syntax without at least one name