Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testcontainers and docker compose support for ClickHouse #42837

Closed

Conversation

eddumelendez
Copy link
Contributor

Testcontainers 1.20.3 provides R2DBC support for ClickHouseContainer.

Testcontainers 1.20.3 provides R2DBC support for ClickHouseContainer.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 22, 2024
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 22, 2024
@philwebb philwebb added this to the 3.x milestone Oct 22, 2024
@snicoll snicoll self-assigned this Oct 23, 2024
@snicoll snicoll changed the title Add container support for ClickHouseContainer R2DBC Add container support for ClickHouseContainer Oct 23, 2024
@snicoll snicoll changed the title Add container support for ClickHouseContainer Add Testcontainers and docker compose support for ClickHouse Oct 23, 2024
@snicoll
Copy link
Member

snicoll commented Oct 23, 2024

I am extending this PR to add support for docker compose as well, including bitnami images. Testing the bitnami image reveals that it doesn't seem easy to customize the database name, I've created bitnami/containers#73550

snicoll pushed a commit that referenced this pull request Oct 23, 2024
snicoll added a commit that referenced this pull request Oct 23, 2024
@snicoll snicoll closed this in 8bb7df3 Oct 23, 2024
@snicoll snicoll modified the milestones: 3.x, 3.4.0-RC1 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants