-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleuth now uses Brave #829
Merged
Merged
Commits on Jan 19, 2018
-
What's done? - Web Server - Simple handler interceptor - Web Clients - RestTemplate - Slf4j - with Brave in place it will also work for any other implementation (e.g. log4j) In progress TraceCallable and TraceRunnable in order to then do stuff with asyncs and then eventually callable on mvc to make the next samples pass.
Configuration menu - View commit details
-
Copy full SHA for 4689302 - Browse repository at this point
Copy the full SHA 4689302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8652d17 - Browse repository at this point
Copy the full SHA 8652d17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61a439c - Browse repository at this point
Copy the full SHA 61a439cView commit details -
there's still the issue546 package to copy but it requires instrumentation of async rest template etc. For now, the goal is to make the async servlet support work
Configuration menu - View commit details
-
Copy full SHA for b9942fe - Browse repository at this point
Copy the full SHA b9942feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 365f418 - Browse repository at this point
Copy the full SHA 365f418View commit details -
Configuration menu - View commit details
-
Copy full SHA for eea7276 - Browse repository at this point
Copy the full SHA eea7276View commit details -
More async stuff added and work on web client started
can't make org.springframework.cloud.brave.instrument.web.TraceWebAsyncClientAutoConfigurationTests pass due to missing client side spans. That's because the `finish()` method in brave returns a null span and the `reporter` is not called.
Configuration menu - View commit details
-
Copy full SHA for e55edad - Browse repository at this point
Copy the full SHA e55edadView commit details -
Configuration menu - View commit details
-
Copy full SHA for f78f435 - Browse repository at this point
Copy the full SHA f78f435View commit details -
Configuration menu - View commit details
-
Copy full SHA for afe5765 - Browse repository at this point
Copy the full SHA afe5765View commit details -
Added instrumentation of rest template
added some tests, added default http client parser
Configuration menu - View commit details
-
Copy full SHA for bc061d8 - Browse repository at this point
Copy the full SHA bc061d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b282b4f - Browse repository at this point
Copy the full SHA b282b4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2243d - Browse repository at this point
Copy the full SHA 0e2243dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5330d95 - Browse repository at this point
Copy the full SHA 5330d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d442b9 - Browse repository at this point
Copy the full SHA 8d442b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b60a309 - Browse repository at this point
Copy the full SHA b60a309View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3267c02 - Browse repository at this point
Copy the full SHA 3267c02View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc452c4 - Browse repository at this point
Copy the full SHA bc452c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64c5f29 - Browse repository at this point
Copy the full SHA 64c5f29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 419ebfb - Browse repository at this point
Copy the full SHA 419ebfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5222be - Browse repository at this point
Copy the full SHA a5222beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d6021f - Browse repository at this point
Copy the full SHA 2d6021fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9c9f0f - Browse repository at this point
Copy the full SHA d9c9f0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cbeb6c - Browse repository at this point
Copy the full SHA 3cbeb6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6d8b9f - Browse repository at this point
Copy the full SHA c6d8b9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e92be65 - Browse repository at this point
Copy the full SHA e92be65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ee4d54 - Browse repository at this point
Copy the full SHA 0ee4d54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cb2786 - Browse repository at this point
Copy the full SHA 0cb2786View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea2187e - Browse repository at this point
Copy the full SHA ea2187eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e78448e - Browse repository at this point
Copy the full SHA e78448eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59fe4dd - Browse repository at this point
Copy the full SHA 59fe4ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40c664f - Browse repository at this point
Copy the full SHA 40c664fView commit details -
Configuration menu - View commit details
-
Copy full SHA for de6d1cc - Browse repository at this point
Copy the full SHA de6d1ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9ded4b - Browse repository at this point
Copy the full SHA e9ded4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11b87d0 - Browse repository at this point
Copy the full SHA 11b87d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4f729e - Browse repository at this point
Copy the full SHA d4f729eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26162c5 - Browse repository at this point
Copy the full SHA 26162c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b227b7 - Browse repository at this point
Copy the full SHA 7b227b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0f6d8c - Browse repository at this point
Copy the full SHA a0f6d8cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.