Add possibility to show scissors and more display options #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto tafel-master
sprain
changed the title
sprain
force-pushed
the
tafel-scissors-master
branch
from
6a429d3
to
d831d42
Compare
sprain
force-pushed
the
tafel-scissors-master
branch
from
0b00016
to
f5aca5a
Compare
|
@tafel @kohlerdominik |
|
Everything is fine, I think. Maybe making $dislpayOptions property private in AbstractOutput class, so we force the usage of the method getDisplayOptions() . This way, it's impossible to miss the call to consolidate() before using the options (I admit this is a very minor problem ^^ ) |
Good catch, thanks! |
|
Sorry, couldn't have a look at it before now. But based on my quick look through it, it's perfect anyway.. Well done! |
|
BTW: according to github this was the 100th closed pull request 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #258 by @tafel
Closes #180
Closes #212
This pull request adds
Output\DisplayOptions, which allows controlling how the separation information on the qr bill is handled:The default variation is also still available – example.
See example code on how to use it.
As a consequence,
AbstractOutput::setPrintable()is now deprecated and will be removed in the next major release.