Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/datasource-name-in-templates #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bensaadaCanine
Copy link

Datasource should be named DS_PROMETHEUS . Not datasource

Jira Ticket

Include a link to your Jira Ticket
Example: JIRAISS-1234

Demo

Please add a recording of the feature/bug fix in work. if you added new routes, the recording should show the request and response for each new/changed route

Checklist:

  • I have filled relevant self assessment (NodeJS, Frontend, Backend)
  • I have run ESlint on my changes and fixed all warnings and errors (NodeJS & Frontend Services)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have validated all the requirements in the Jira task were answered
  • I have all neccessary approvals for the design/mini design of this task
  • I have approved the API changes and granular permission patterns (documentation subtask) (For public services only)

Datasource should be named `DS_PROMETHEUS` .Not `datasource`
@mic-goldberg-spot
Copy link
Collaborator

mic-goldberg-spot commented Sep 9, 2024

@bensaadaCanine can you please share any resource where this requirement is specified.
Or provide an example when using the other than DS_PROMETHEUS name for the variable of the type Data source will lead to broken functionality.

@bensaadaCanine
Copy link
Author

@mic-goldberg-spot this is the error I got before this fix:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants