Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional path specification to libssh.h, and instruction to use brew (for Mac) #25

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

guoquan
Copy link
Contributor

@guoquan guoquan commented Nov 11, 2020

Hence Mac is supported

@guoquan guoquan mentioned this pull request Nov 11, 2020
@ericcurtin
Copy link
Contributor

ericcurtin commented Nov 11, 2020

Apple silicon support next? Hopefully it will just build 😄

@studgeek
Copy link

It looks like this was approved, but not merged?

@ericcurtin
Copy link
Contributor

I actually just got a M1 Mac Mini for some aarch64 work I'm doing, might give this branch a whirl to see if it's still working today.

@wongjustin99
Copy link

Location is slightly different for me on an M1 using the same brew package.

LIBSSH_INCLUDE2 = /opt/homebrew/Cellar/libssh/0.9.6/include/libssh/libssh.h

Still working through it though, the includes in src/sshping.cos are not picking up the updated header path it seems.

@wongjustin99
Copy link

Using #27, I was able to get running as well.

@spook spook merged commit 7f31b30 into spook:master Mar 3, 2023
@code-ape
Copy link

code-ape commented Mar 3, 2023

Just tried this after merge and still having issues. I'm on an M1 MacBook Pro running the following, any suggestions?

brew install libssh
make -e LIBSSH_INCLUDE=/opt/homebrew/Cellar/libssh/0.10.4/include/libssh/libssh.h

Output is:

g++ -Wall -I ext/ -o bin/sshping src/sshping.cxx -lssh
src/sshping.cxx:38:10: fatal error: 'libssh/libssh.h' file not found
#include <libssh/libssh.h>
         ^~~~~~~~~~~~~~~~~
1 error generated.
make: *** [bin/sshping] Error 1

@hologerry
Copy link

Just tried this after merge and still having issues. I'm on an M1 MacBook Pro running the following, any suggestions?

brew install libssh
make -e LIBSSH_INCLUDE=/opt/homebrew/Cellar/libssh/0.10.4/include/libssh/libssh.h

Output is:

g++ -Wall -I ext/ -o bin/sshping src/sshping.cxx -lssh
src/sshping.cxx:38:10: fatal error: 'libssh/libssh.h' file not found
#include <libssh/libssh.h>
         ^~~~~~~~~~~~~~~~~
1 error generated.
make: *** [bin/sshping] Error 1

For future users:
change the CMakeLists.txt according to: #27
And do the following

mkdir build
cd build
cmake ..
make
# sudo make install

@guoquan guoquan deleted the patch-1 branch July 27, 2024 12:27
@guoquan
Copy link
Contributor Author

guoquan commented Jul 27, 2024

For Mac users with issue locating libssh.h, please also consult #23

It may be good if someone can propose a PR with $(CFLAGS) ready and compile instruction in README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants