Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "penetrated" field type on document #1036

Closed
wants to merge 1 commit into from
Closed

Fix "penetrated" field type on document #1036

wants to merge 1 commit into from

Conversation

FlowingSPDG
Copy link

Fix "penetrated" field type on player_death event.

@nickdnk nickdnk closed this Aug 4, 2023
@nickdnk
Copy link
Collaborator

nickdnk commented Aug 4, 2023

Hello

penetrated is the number of objects the bullet went through. If you want to evaluate it as boolean, just check for > 0.

@nickdnk nickdnk reopened this Aug 4, 2023
@nickdnk
Copy link
Collaborator

nickdnk commented Aug 4, 2023

Sorry, I thought it was changed the other way around; from number to boolean. This is correct.

@nickdnk
Copy link
Collaborator

nickdnk commented Aug 4, 2023

Please change it from number to integer and I will merge it.

@nickdnk nickdnk mentioned this pull request Aug 4, 2023
Merged
@nickdnk
Copy link
Collaborator

nickdnk commented Aug 4, 2023

Fixed with #1037 as there was another instance of integer/number error on bomb timer.

@nickdnk nickdnk closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlowingSPDG @nickdnk