Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help output correctly decides when to show the version option #1664

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Help output correctly decides when to show the version option #1664

wants to merge 16 commits into from

Commits on Oct 4, 2024

  1. New unit tests to ensure unknown flags are added to remaining args

    @FrankRay78
    FrankRay78 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b60cff7 View commit details
    Browse the repository at this point in the history

  2. Cosmetic: Remove ugly looking variable naming

    @FrankRay78
    FrankRay78 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    332bea1 View commit details
    Browse the repository at this point in the history

  3. Add strict parsing to almost all branches tests, an obvious omission

    @FrankRay78
    FrankRay78 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    04208d8 View commit details
    Browse the repository at this point in the history

  4. Fix tests with incorrect validation that were in the main branch 

    Tests had incorrect expectations for the parsing of branch + default command arguments
    @FrankRay78
    FrankRay78 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c33a4cf View commit details
    Browse the repository at this point in the history

  5. Significant improvement to the command line parsing

    @FrankRay78
    FrankRay78 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e69888a View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Cover -v and --version options in unit tests

    @FrankRay78
    FrankRay78 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    3aabf7a View commit details
    Browse the repository at this point in the history

  2. Display the application version (if set) when a version flag is the f… 

    …irst argument, even if a default command has been set.
    @FrankRay78
    FrankRay78 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f3ef88a View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary using directive

    @FrankRay78
    FrankRay78 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5c4d894 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Unit tests to ensure VersionCommand executes when -v|--version is spe… 

    …cified, rather than showing the ApplicationVersion number
    @FrankRay78
    FrankRay78 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    15ecf9a View commit details
    Browse the repository at this point in the history

  2. Check if the command has a version option on its setting class

    @FrankRay78
    FrankRay78 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2b357f7 View commit details
    Browse the repository at this point in the history

  3. Add strict parsing to all version tests, an obvious omission in main

    @FrankRay78
    FrankRay78 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6142307 View commit details
    Browse the repository at this point in the history

  4. Bug fix: Tests with remaining args should not be expected to pass str… 

    …ict parsing
    @FrankRay78
    FrankRay78 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    592822a View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Updated test names for better self-documentation

    @FrankRay78
    FrankRay78 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2df6c22 View commit details
    Browse the repository at this point in the history

  2. Help writer unit tests; including coverage of when the -v|--version s… 

    …hould (and shouldn't) appear in the help output
    @FrankRay78
    FrankRay78 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    32e79f9 View commit details
    Browse the repository at this point in the history

  3. Improved unit test coverage using Spectre.Console.Tests.Data.VersionC… 

    …ommand
    @FrankRay78
    FrankRay78 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    dae2041 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Tighten up when to show/hide the application "-v|--version" option.

    @FrankRay78
    FrankRay78 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    47f3703 View commit details
    Browse the repository at this point in the history