clippy
14 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 14 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.0 (79e9716c9 2023-11-13)
- cargo 1.74.0 (ecb9851af 2023-10-18)
- clippy 0.1.74 (79e9716 2023-11-13)
Annotations
Check warning on line 13 in src/type/specta_id.rs
github-actions / clippy
you are deriving `Hash` but have implemented `PartialEq` explicitly
warning: you are deriving `Hash` but have implemented `PartialEq` explicitly
--> src/type/specta_id.rs:13:30
|
13 | #[derive(Debug, Clone, Copy, Hash)]
| ^^^^
|
note: `PartialEq` implemented here
--> src/type/specta_id.rs:39:1
|
39 | impl PartialEq<Self> for SpectaID {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derived_hash_with_manual_eq
= note: `#[warn(clippy::derived_hash_with_manual_eq)]` implied by `#[warn(clippy::all)]`
= note: this warning originates in the derive macro `Hash` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 181 in src/serde.rs
github-actions / clippy
length comparison to zero
warning: length comparison to zero
--> src/serde.rs:181:31
|
181 | if valid_variants == 0 && e.variants().len() != 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!e.variants().is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
Check warning on line 96 in src/serde.rs
github-actions / clippy
`panic` should not be present in production code
warning: `panic` should not be present in production code
--> src/serde.rs:96:40
|
96 | .unwrap_or_else(|| panic!("Type '{}' was never populated.", ty.sid.type_name)); // TODO: Error properly
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
Check warning on line 94 in src/serde.rs
github-actions / clippy
`panic` should not be present in production code
warning: `panic` should not be present in production code
--> src/serde.rs:94:40
|
94 | .unwrap_or_else(|| panic!("Reference type not found for: {}", ty.sid.type_name))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
note: the lint level is defined here
--> src/lib.rs:3:43
|
3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs
| ^^^^^^^^^^^^^
Check warning on line 650 in src/lang/ts/mod.rs
github-actions / clippy
called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
--> src/lang/ts/mod.rs:650:31
|
650 | if let Some(first_char) = ident.chars().nth(0) {
| ^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `ident.chars().next()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
= note: `#[warn(clippy::iter_nth_zero)]` implied by `#[warn(clippy::all)]`
Check warning on line 446 in src/lang/ts/mod.rs
github-actions / clippy
length comparison to zero
warning: length comparison to zero
--> src/lang/ts/mod.rs:446:24
|
446 | if obj.fields.len() == 0 {
| ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `obj.fields.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` implied by `#[warn(clippy::all)]`
Check warning on line 234 in src/lang/ts/mod.rs
github-actions / clippy
useless conversion to the same type: `std::ops::Range<usize>`
warning: useless conversion to the same type: `std::ops::Range<usize>`
--> src/lang/ts/mod.rs:233:21
|
233 | / (0..length)
234 | | .into_iter()
| |____________________________________^ help: consider removing `.into_iter()`: `(0..length)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` implied by `#[warn(clippy::all)]`
Check warning on line 227 in src/lang/ts/mod.rs
github-actions / clippy
useless use of `format!`
warning: useless use of `format!`
--> src/lang/ts/mod.rs:227:17
|
227 | format!("{dt}")
| ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `dt.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` implied by `#[warn(clippy::all)]`
Check warning on line 223 in src/lang/ts/mod.rs
github-actions / clippy
single-character string constant used as pattern
warning: single-character string constant used as pattern
--> src/lang/ts/mod.rs:223:74
|
223 | || (dt.contains(' ') && (dt.contains("&") || dt.contains("|")))
| ^^^ help: try using a `char` instead: `'|'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
Check warning on line 223 in src/lang/ts/mod.rs
github-actions / clippy
single-character string constant used as pattern
warning: single-character string constant used as pattern
--> src/lang/ts/mod.rs:223:54
|
223 | || (dt.contains(' ') && (dt.contains("&") || dt.contains("|")))
| ^^^ help: try using a `char` instead: `'&'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` implied by `#[warn(clippy::all)]`
Check warning on line 106 in src/lang/ts/mod.rs
github-actions / clippy
using a reference to `Cow` is not recommended
warning: using a reference to `Cow` is not recommended
--> src/lang/ts/mod.rs:106:11
|
106 | docs: &Cow<'static, str>,
| ^^^^^^^^^^^^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` implied by `#[warn(clippy::all)]`
Check warning on line 72 in src/lang/ts/js_doc.rs
github-actions / clippy
calling `push_str()` using a single-character string literal
warning: calling `push_str()` using a single-character string literal
--> src/lang/ts/js_doc.rs:72:9
|
72 | self.value.push_str("\n");
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `self.value.push('\n')`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
= note: `#[warn(clippy::single_char_add_str)]` implied by `#[warn(clippy::all)]`
Check warning on line 21 in src/lang/ts/comments.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lang/ts/comments.rs:21:33
|
21 | builder.push_deprecated(&deprecated);
| ^^^^^^^^^^^ help: change this to: `deprecated`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
note: the lint level is defined here
--> src/lib.rs:3:9
|
3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs
| ^^^^^^^^^^^
= note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
Check warning on line 66 in src/lang/ts/reserved_terms.rs
github-actions / clippy
constant `RESERVED_IDENTS` is never used
warning: constant `RESERVED_IDENTS` is never used
--> src/lang/ts/reserved_terms.rs:66:18
|
66 | pub(crate) const RESERVED_IDENTS: &[&str] = &[
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default