Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The high-level thinking is to separate the idea of a Rust declaration and a Typescript type. Would this mean we can remove
Any
,Unknown
andPrimitiveType/LiteralType::None
.Questions:
List
andMap
constructors deal withinline
vsreference
DataType::Nullable(DataType::Nullable(...))
which is not great. Should we have it be more split up.DataTypeFrom
fit into this?Type::inline
go and instead haveReference { inline: true }
and post-process it?Reference
andDatTypeReference
?? I feel like it makes it more typesafe so probs.inline
anddefinition
become one method and thegenerics
arg is an enum instead.NamedType
???TODO:
ImplLocation
be constructed usinguse_caller
? Should it be removed?List
constructorMap
constructorDataType::is
SpectaID
including primitives.std::convert::Infallible
should be rejected by the Serde validator.List
andMap
toListType
andMapType
!
but with Serde exporter warningTied to #203 and #140.