Skip to content

Bump rest of versions #410

Bump rest of versions

Bump rest of versions #410

Triggered via push July 9, 2024 13:45
Status Failure
Total duration 1m 31s
Artifacts

ci.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 275 warnings
build (macos-latest)
Process completed with exit code 101.
build (windows-latest)
The job was canceled because "macos-latest" failed.
build (windows-latest)
The operation was canceled.
build (ubuntu-latest)
The job was canceled because "macos-latest" failed.
build (ubuntu-latest)
The operation was canceled.
`panic` should not be present in production code: specta-zod/src/lib.rs#L653
warning: `panic` should not be present in production code --> specta-zod/src/lib.rs:653:22 | 653 | _ => panic!("unhandled literal type!"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic = note: requested on the command line with `-W clippy::panic`
this expression always evaluates to true: specta-zod/src/lib.rs#L119
warning: this expression always evaluates to true --> specta-zod/src/lib.rs:119:47 | 119 | let prefix = match start_with_newline && !comments.is_empty() { | ^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_is_empty = note: `-W clippy::const-is-empty` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::const_is_empty)]`
package `specta-zod` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-zod/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
field `0` is never read: specta-zod/src/context.rs#L8
warning: field `0` is never read --> specta-zod/src/context.rs:8:18 | 8 | TypeExtended(Cow<'static, str>, ImplLocation), | ------------ ^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 8 | TypeExtended((), ImplLocation), | ~~
passing a unit value to a function: specta-typescript/src/lib.rs#L656
warning: passing a unit value to a function --> specta-typescript/src/lib.rs:656:5 | 656 | / Ok(match &e.repr() { 657 | | EnumRepr::Untagged => { 658 | | let mut variants = e 659 | | .variants() ... | 795 | | } 796 | | }) | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg help: move the expression in front of the call and replace it with the unit literal `()` | 656 ~ match &e.repr() { 657 + EnumRepr::Untagged => { 658 + let mut variants = e 659 + .variants() 660 + .iter() 661 + .filter(|(_, variant)| !variant.skip()) 662 + .map(|(name, variant)| { 663 + Ok(match variant.inner() { 664 + EnumVariants::Unit => NULL.to_string(), 665 + _ => inner_comments( 666 + ctx.clone(), 667 + variant.deprecated(), 668 + variant.docs(), 669 + enum_variant_datatype( 670 + ctx.with(PathItem::Variant(name.clone())), 671 + type_map, 672 + name.clone(), 673 + variant, 674 + )? 675 + .expect("Invalid Serde type"), 676 + true, 677 + ), 678 + }) 679 + }) 680 + .collect::<Result<Vec<_>>>()?; 681 + variants.dedup(); 682 + s.push_str(&variants.join(" | ")); 683 + } 684 + repr => { 685 + let mut variants = e 686 + .variants() 687 + .iter() 688 + .filter(|(_, variant)| !variant.skip()) 689 + .map(|(variant_name, variant)| { 690 + let sanitised_name = sanitise_key(variant_name.clone(), true); 691 + 692 + Ok(inner_comments( 693 + ctx.clone(), 694 + variant.deprecated(), 695 + variant.docs(), 696 + match (repr, &variant.inner()) { 697 + (EnumRepr::Untagged, _) => unreachable!(), 698 + (EnumRepr::Internal { tag }, EnumVariants::Unit) => { 699 + format!("{{ {tag}: {sanitised_name} }}") 700 + } 701 + (EnumRepr::Internal { tag }, EnumVariants::Unnamed(tuple)) => { 702 + let fields = skip_fields(tuple.fields()).collect::<Vec<_>>(); 703 + 704 + // This field is only required for `{ty}` not `[...]` so we only need to check when there one field 705 + let dont_join_ty = if tuple.fields().len() == 1 { 706 + let (_, ty) = fields.first().expect("checked length above"); 707 + validate_type_for_tagged_intersection( 708 + ctx.clone(), 709 + (**ty).clone(), 710 + type_map, 711 + )? 712 + } else { 713 + false 714 + }; 715 + 716 + let mut typ = String::new(); 717 + 718 + unnamed_fields_datatype(ctx.clone(), &fields, type_map, &mut typ)?; 719 + 720 + if dont_join_ty { 721 + format!("({{ {tag}: {sanitised_name} }})") 722 + } else { 723 + // We wanna be sure `... & ... | ...` becomes `... & (... | ...)` 724 + if typ.contains('|') { 725 + typ = format!("({typ})"); 726 + } 727 + format!("({{ {tag}: {sanitised_name} }} & {typ})") 728 + } 729 + } 730 + (EnumRepr::Internal { tag }, EnumVariants::Named(obj)) => { 731 + let mut fields = vec![format!("{tag}: {sanitised_name}")]; 732 + 733 + for (name, field) in skip_fields_named(obj.fields()) { 734 + let mut other = String::new(); 735 + object_field_to_ts( 736 + ctx.with(PathItem::Field(name.clone())), 737 + name.clone(), 738 + field, 739 + type_map, 740 + &mut other, 741 + )?; 742 + fields.push(other); 743 + } 744 + 745 + format!("{{ {} }}", fields.join("; ")) 746 + } 747 + (EnumRepr::External, EnumVariants::Unit) => sanitised_name.to_string(), 748 + (EnumRepr::External, _) => { 749 + let ts_values = enum_variant_datatype( 750 + ctx.with(PathItem::Variant(variant_name.clone())), 751 + type_map, 752 + variant_name.clone(), 753 + variant, 754 + )?; 755 + let sanitised_name = sanitise_key(variant_name.clone(), false); 756 + 757 + match ts_values { 758 + Some(ts_values) => { 759 + format!("{{ {sanitised_name}: {ts_values} }}") 760 + } 761 + None => format!(r#""{sanitised_name}""#), 762 + } 763 + } 764 + (EnumRepr::Adjacent { tag, .. }, EnumVariants::Unit) => { 765 + format!("{{ {tag}: {sanitised_name} }}") 766 + } 767 + (EnumRepr::Adjacent { tag, content }, _) => { 768 + let ts_value = enum_variant_datatype( 769 + ctx.with(PathItem::Variant(variant_name.clone())), 770 + type_map, 771 + variant_name.clone(), 772 + variant, 773 + )?; 774 + 775 + let mut s = String::new(); 776 + 777 + s.push_str("{ "); 778 + 779 + write!(s, "{tag}: {sanitised_name}")?; 780 + if let Some(ts_value) = ts_value { 781 + write!(s, "; {content}: {ts_value}")?; 782 + } 783 + 784 + s.push_str(" }"); 785 + 786 + s 787 + } 788 + }, 789 + true, 790 + )) 791 + }) 792 + .collect::<Result<Vec<_>>>()?; 793 + variants.dedup(); 794 + s.push_str(&variants.join(" | ")); 795 + } 796 + }; 797 + Ok(()) |
passing a unit value to a function: specta-typescript/src/lib.rs#L510
warning: passing a unit value to a function --> specta-typescript/src/lib.rs:510:24 | 510 | return Ok(match named.tag().as_ref() { | ________________________^ 511 | | Some(tag) => write!(s, r#"{{ "{tag}": "{key}" }}"#)?, 512 | | None => write!(s, "Record<{STRING}, {NEVER}>")?, 513 | | }); | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg help: move the expression in front of the call and replace it with the unit literal `()` | 510 ~ return { 511 + match named.tag().as_ref() { 512 + Some(tag) => write!(s, r#"{{ "{tag}": "{key}" }}"#)?, 513 + None => write!(s, "Record<{STRING}, {NEVER}>")?, 514 + }; 515 + Ok(()) 516 ~ }; |
passing a unit value to a function: specta-typescript/src/lib.rs#L498
warning: passing a unit value to a function --> specta-typescript/src/lib.rs:498:5 | 498 | / Ok(match &strct.fields() { 499 | | StructFields::Unit => s.push_str(NULL), 500 | | StructFields::Unnamed(unnamed) => unnamed_fields_datatype( 501 | | ctx, ... | 569 | | } 570 | | }) | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg help: move the expression in front of the call and replace it with the unit literal `()` | 498 ~ match &strct.fields() { 499 + StructFields::Unit => s.push_str(NULL), 500 + StructFields::Unnamed(unnamed) => unnamed_fields_datatype( 501 + ctx, 502 + &skip_fields(unnamed.fields()).collect::<Vec<_>>(), 503 + type_map, 504 + s, 505 + )?, 506 + StructFields::Named(named) => { 507 + let fields = skip_fields_named(named.fields()).collect::<Vec<_>>(); 508 + 509 + if fields.is_empty() { 510 + return Ok(match named.tag().as_ref() { 511 + Some(tag) => write!(s, r#"{{ "{tag}": "{key}" }}"#)?, 512 + None => write!(s, "Record<{STRING}, {NEVER}>")?, 513 + }); 514 + } 515 + 516 + let (flattened, non_flattened): (Vec<_>, Vec<_>) = 517 + fields.iter().partition(|(_, (f, _))| f.flatten()); 518 + 519 + let mut field_sections = flattened 520 + .into_iter() 521 + .map(|(key, (field, ty))| { 522 + let mut s = String::new(); 523 + datatype_inner(ctx.with(PathItem::Field(key.clone())), ty, type_map, &mut s) 524 + .map(|_| { 525 + inner_comments( 526 + ctx.clone(), 527 + field.deprecated(), 528 + field.docs(), 529 + format!("({s})"), 530 + true, 531 + ) 532 + }) 533 + }) 534 + .collect::<Result<Vec<_>>>()?; 535 + 536 + let mut unflattened_fields = non_flattened 537 + .into_iter() 538 + .map(|(key, field_ref)| { 539 + let (field, _) = field_ref; 540 + 541 + let mut other = String::new(); 542 + object_field_to_ts( 543 + ctx.with(PathItem::Field(key.clone())), 544 + key.clone(), 545 + field_ref, 546 + type_map, 547 + &mut other, 548 + )?; 549 + 550 + Ok(inner_comments( 551 + ctx.clone(), 552 + field.deprecated(), 553 + field.docs(), 554 + other, 555 + true, 556 + )) 557 + }) 558 + .collect::<Result<Vec<_>>>()?; 559 + 560 + if let Some(tag) = &named.tag() { 561 + unflattened_fields.push(format!("{tag}: \"{key}\"")); 562 + } 563 + 564 + if !unflattened_fields.is_empty() { 565 + field_sections.push(format!("{{ {} }}", unflattened_fields.join("; "))); 566 + } 567 + 568 + s.push_str(&field_sections.join(" & ")); 569 + } 570 + }; 571 + Ok(()) |
passing a unit value to a function: specta-typescript/src/lib.rs#L439
warning: passing a unit value to a function --> specta-typescript/src/lib.rs:439:5 | 439 | / Ok(match fields { 440 | | [(field, ty)] => { 441 | | let mut v = String::new(); 442 | | datatype_inner(ctx.clone(), ty, type_map, &mut v)?; ... | 471 | | } 472 | | }) | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg help: move the expression in front of the call and replace it with the unit literal `()` | 439 ~ match fields { 440 + [(field, ty)] => { 441 + let mut v = String::new(); 442 + datatype_inner(ctx.clone(), ty, type_map, &mut v)?; 443 + s.push_str(&inner_comments( 444 + ctx, 445 + field.deprecated(), 446 + field.docs(), 447 + v, 448 + true, 449 + )); 450 + } 451 + fields => { 452 + s.push('['); 453 + 454 + for (i, (field, ty)) in fields.iter().enumerate() { 455 + if i != 0 { 456 + s.push_str(", "); 457 + } 458 + 459 + let mut v = String::new(); 460 + datatype_inner(ctx.clone(), ty, type_map, &mut v)?; 461 + s.push_str(&inner_comments( 462 + ctx.clone(), 463 + field.deprecated(), 464 + field.docs(), 465 + v, 466 + true, 467 + )); 468 + } 469 + 470 + s.push(']'); 471 + } 472 + }; 473 + Ok(()) |
this expression creates a reference which is immediately dereferenced by the compiler: specta-typescript/src/lib.rs#L409
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-typescript/src/lib.rs:409:28 | 409 | s.push_str(&reference.name()); | ^^^^^^^^^^^^^^^^^ help: change this to: `reference.name()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-typescript/src/lib.rs#L407
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-typescript/src/lib.rs:407:30 | 407 | [] => s.push_str(&reference.name()), | ^^^^^^^^^^^^^^^^^ help: change this to: `reference.name()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-typescript/src/lib.rs#L334
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-typescript/src/lib.rs:334:33 | 334 | datatype_inner(ctx, &def.ty(), type_map, &mut dt)?; | ^^^^^^^^^ help: change this to: `def.ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
passing a unit value to a function: specta-typescript/src/lib.rs#L276
warning: passing a unit value to a function --> specta-typescript/src/lib.rs:276:5 | 276 | / Ok(match &typ { 277 | | DataType::Any => s.push_str(ANY), 278 | | DataType::Unknown => s.push_str(UNKNOWN), 279 | | DataType::Primitive(p) => { ... | 428 | | DataType::Generic(ident) => s.push_str(&ident.to_string()), 429 | | }) | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg = note: `-W clippy::unit-arg` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unit_arg)]` help: move the expression in front of the call and replace it with the unit literal `()` | 276 ~ match &typ { 277 + DataType::Any => s.push_str(ANY), 278 + DataType::Unknown => s.push_str(UNKNOWN), 279 + DataType::Primitive(p) => { 280 + let ctx = ctx.with(PathItem::Type(p.to_rust_str().into())); 281 + let str = match p { 282 + primitive_def!(i8 i16 i32 u8 u16 u32 f32 f64) => NUMBER, 283 + primitive_def!(usize isize i64 u64 i128 u128) => match ctx.cfg.bigint { 284 + BigIntExportBehavior::String => STRING, 285 + BigIntExportBehavior::Number => NUMBER, 286 + BigIntExportBehavior::BigInt => BIGINT, 287 + BigIntExportBehavior::Fail => { 288 + return Err(ExportError::BigIntForbidden(ctx.export_path())); 289 + } 290 + BigIntExportBehavior::FailWithReason(reason) => { 291 + return Err(ExportError::Other(ctx.export_path(), reason.to_owned())) 292 + } 293 + }, 294 + primitive_def!(String char) => STRING, 295 + primitive_def!(bool) => BOOLEAN, 296 + }; 297 + 298 + s.push_str(str); 299 + } 300 + DataType::Literal(literal) => match literal { 301 + LiteralType::i8(v) => write!(s, "{v}")?, 302 + LiteralType::i16(v) => write!(s, "{v}")?, 303 + LiteralType::i32(v) => write!(s, "{v}")?, 304 + LiteralType::u8(v) => write!(s, "{v}")?, 305 + LiteralType::u16(v) => write!(s, "{v}")?, 306 + LiteralType::u32(v) => write!(s, "{v}")?, 307 + LiteralType::f32(v) => write!(s, "{v}")?, 308 + LiteralType::f64(v) => write!(s, "{v}")?, 309 + LiteralType::bool(v) => write!(s, "{v}")?, 310 + LiteralType::String(v) => write!(s, r#""{v}""#)?, 311 + LiteralType::char(v) => write!(s, r#""{v}""#)?, 312 + LiteralType::None => s.write_str(NULL)?, 313 + _ => unreachable!(), 314 + }, 315 + DataType::Nullable(def) => { 316 + datatype_inner(ctx, def, type_map, s)?; 317 + 318 + let or_null = format!(" | {NULL}"); 319 + if !s.ends_with(&or_null) { 320 + s.push_str(&or_null); 321 + } 322 + } 323 + DataType::Map(def) => { 324 + // We use this instead of `Record<K, V>` to avoid issues with circular references. 325 + s.push_str("{ [key in "); 326 + datatype_inner(ctx.clone(), def.key_ty(), type_map, s)?; 327 + s.push_str("]: "); 328 + datatype_inner(ctx.clone(), def.value_ty(), type_map, s)?; 329 + s.push_str(" }"); 330 + } 331 + // We use `T[]` instead of `Array<T>` to avoid issues with circular references. 332 + DataType::List(def) => { 333 + let mut dt = String::new(); 334 + datatype_inner(ctx, &def.ty(), type_map, &mut dt)?; 335 + 336 + let dt = if (dt.contains(' ') && !dt.ends_with('}')) 337 + // This is to do with maintaining order of operations. 338 + // Eg `{} | {}` must be wrapped in parens like `({} | {})[]` but `{}` doesn't cause `{}[]` is valid 339 + || (dt.contains(' ') && (dt.contains('&') || dt.contains('|'))) 340 + { 341 + format!("({dt})") 342 + } else { 343 + dt 344 + }; 345 + 346 + if let Some(length) = def.length() { 347 + s.push('['); 348 + 349 + for n in 0..length { 350 + if n != 0 { 351 + s.push_str(", "); 352 + } 353 + 354 + s.push_str(&dt); 355 + } 356 + 357 + s.push(']'); 358 + } else { 359 + write!(s, "{dt}[]")?; 360 + } 361 + } 362 + DataType::Struct(item) => struct_datatype( 363 + ctx.with( 364 + item.sid() 365 + .and_then(|sid| type_map.get(*sid)) 366 + .and_then(|v| v.ext()) 367 + .map(|v| PathItem::TypeExtended(item.name().clone(), *v.impl_location())) 368 + .unwrap_or_else(|| PathItem::Type(item.name().clone())), 369 + ), 370 + item.name(), 371 + item, 372 + type_map, 373 + s, 374 + )?, 375 + DataType::Enum(item) => { 376 + let mut ctx = ctx.clone(); 377 + let cfg = ctx.cfg.clone().bigint(BigIntExportBehavior::Number); 378 + if item.skip_bigint_checks() { 379 + ctx.cfg = &cfg; 380 + } 381 + 382 + enum_datatype( 383 + ctx.with(PathItem::Variant(item.name().clone())), 384 + item, 385 + type_map, 386 + s, 387 + )? 388 + } 389 + DataType::Tuple(tuple) => s.push_str(&tuple_datatype(ctx, tuple, type_map)?), 390 + DataType::Result(result) => { 391 + let mut variants = vec![ 392 + { 393 + let mut v = String::new(); 394 + datatype_inner(ctx.clone(), &result.0, type_map, &mut v)?; 395 + v 396 + }, 397 + { 398 + let mut v = String::new(); 399 + datatype_inner(ctx, &result.1, type_map, &mut v)?; 400 + v 401 + }, 402 + ]; 403 + variants.dedup(); 404 + s.push_str(&variants.join(" | ")); 405 + } 406 + DataType::Reference(reference) => match &reference.generics()[..] { 407 + [] => s.push_str(&reference.name()), 408 + generics => { 409 + s.push_str(&reference.name()); 410 + s.push('<'); 411 + 412 + for (i, (_, v)) in generics.iter().enumerate() { 413 + if i != 0 { 414 + s.push_str(", "); 415 + } 416 + 417 + datatype_inner( 418 + ctx.with(PathItem::Type(reference.name().clone())), 419 + v, 420 + type_map, 421 + s, 422 + )?; 423 + } 424 + 425 + s.push('>'); 426 + } 427 + }, 428 + DataType::Generic(ident) => s.push_str(&ident.to_string()), 429 + }; 430 + Ok(()) |
using `clone` on type `Option<&NamedDataTypeExt>` which implements the `Copy` trait: specta-typescript/src/lib.rs#L220
warning: using `clone` on type `Option<&NamedDataTypeExt>` which implements the `Copy` trait --> specta-typescript/src/lib.rs:220:9 | 220 | ext.clone() | ^^^^^^^^^^^ help: try removing the `clone` call: `ext` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `-W clippy::clone-on-copy` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::clone_on_copy)]`
calling `push_str()` using a single-character string literal: specta-typescript/src/lib.rs#L182
warning: calling `push_str()` using a single-character string literal --> specta-typescript/src/lib.rs:182:5 | 182 | s.push_str(";"); | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(';')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
calling `push_str()` using a single-character string literal: specta-typescript/src/lib.rs#L175
warning: calling `push_str()` using a single-character string literal --> specta-typescript/src/lib.rs:175:5 | 175 | s.push_str(")"); | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push(')')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str
calling `push_str()` using a single-character string literal: specta-typescript/src/lib.rs#L165
warning: calling `push_str()` using a single-character string literal --> specta-typescript/src/lib.rs:165:5 | 165 | s.push_str("("); | ^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('(')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `-W clippy::single-char-add-str` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::single_char_add_str)]`
package `specta-zod` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-typescript/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
constant `RESERVED_IDENTS` is never used: specta-typescript/src/reserved_terms.rs#L66
warning: constant `RESERVED_IDENTS` is never used --> specta-typescript/src/reserved_terms.rs:66:18 | 66 | pub(crate) const RESERVED_IDENTS: &[&str] = &[ | ^^^^^^^^^^^^^^^
method `push_generic` is never used: specta-typescript/src/js_doc.rs#L98
warning: method `push_generic` is never used --> specta-typescript/src/js_doc.rs:98:12 | 59 | impl Builder { | ------------ method in this implementation ... 98 | pub fn push_generic(&mut self, generic: &GenericType) { | ^^^^^^^^^^^^
function `typedef_named_datatype_inner` is never used: specta-typescript/src/js_doc.rs#L24
warning: function `typedef_named_datatype_inner` is never used --> specta-typescript/src/js_doc.rs:24:4 | 24 | fn typedef_named_datatype_inner( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
function `typedef_named_datatype` is never used: specta-typescript/src/js_doc.rs#L7
warning: function `typedef_named_datatype` is never used --> specta-typescript/src/js_doc.rs:7:8 | 7 | pub fn typedef_named_datatype( | ^^^^^^^^^^^^^^^^^^^^^^
field `0` is never read: specta-typescript/src/context.rs#L10
warning: field `0` is never read --> specta-typescript/src/context.rs:10:18 | 10 | TypeExtended(Cow<'static, str>, ImplLocation), | ------------ ^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 10 | TypeExtended((), ImplLocation), | ~~
`todo` should not be present in production code: specta-rust/src/lib.rs#L73
warning: `todo` should not be present in production code --> specta-rust/src/lib.rs:73:30 | 73 | DataType::Enum(_) => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-rust/src/lib.rs#L71
warning: `todo` should not be present in production code --> specta-rust/src/lib.rs:71:13 | 71 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
redundant closure: specta-rust/src/lib.rs#L38
warning: redundant closure --> specta-rust/src/lib.rs:38:26 | 38 | .map(|v| datatype(v)) | ^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `datatype` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `-W clippy::redundant-closure` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::redundant_closure)]`
this expression creates a reference which is immediately dereferenced by the compiler: specta-rust/src/lib.rs#L29
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-rust/src/lib.rs:29:22 | 29 | datatype(&t.value_ty())? | ^^^^^^^^^^^^^ help: change this to: `t.value_ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-rust/src/lib.rs#L28
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-rust/src/lib.rs:28:22 | 28 | datatype(&t.key_ty())?, | ^^^^^^^^^^^ help: change this to: `t.key_ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
`todo` should not be present in production code: specta-rust/src/lib.rs#L24
warning: `todo` should not be present in production code --> specta-rust/src/lib.rs:24:33 | 24 | DataType::Literal(_) => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-rust/src/lib.rs#L21
warning: `todo` should not be present in production code --> specta-rust/src/lib.rs:21:30 | 21 | DataType::Unknown => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-rust/src/lib.rs#L20
warning: `todo` should not be present in production code --> specta-rust/src/lib.rs:20:32 | 20 | DataType::Result(_) => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`
`todo` should not be present in production code: specta-kotlin/src/lib.rs#L101
warning: `todo` should not be present in production code --> specta-kotlin/src/lib.rs:101:14 | 101 | _ => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-kotlin/src/lib.rs#L98
warning: `todo` should not be present in production code --> specta-kotlin/src/lib.rs:98:13 | 98 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`
this expression creates a reference which is immediately dereferenced by the compiler: specta-kotlin/src/lib.rs#L61
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-kotlin/src/lib.rs:61:58 | 61 | DataType::Nullable(t) => format!("{}?", datatype(&t)?), | ^^ help: change this to: `t` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-kotlin/src/lib.rs#L41
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-kotlin/src/lib.rs:41:22 | 41 | datatype(&t.value_ty())? | ^^^^^^^^^^^^^ help: change this to: `t.value_ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-kotlin/src/lib.rs#L40
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-kotlin/src/lib.rs:40:22 | 40 | datatype(&t.key_ty())?, | ^^^^^^^^^^^ help: change this to: `t.key_ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
`todo` should not be present in production code: specta-go/src/lib.rs#L16
warning: `todo` should not be present in production code --> specta-go/src/lib.rs:16:5 | 16 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`
unused import: `NamedDataType`: specta-typescript/src/typescript.rs#L1
warning: unused import: `NamedDataType` --> specta-typescript/src/typescript.rs:1:24 | 1 | use specta::{Language, NamedDataType, TypeMap}; | ^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
package `specta-zod` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-rust/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
unused variable: `s`: specta-rust/src/lib.rs#L43
warning: unused variable: `s` --> specta-rust/src/lib.rs:43:26 | 43 | DataType::Struct(s) => { | ^ help: if this is intentional, prefix it with an underscore: `_s` | = note: `#[warn(unused_variables)]` on by default
package `specta-zod` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-go/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
package `specta-zod` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-kotlin/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
unused variable: `t`: specta-go/src/lib.rs#L15
warning: unused variable: `t` --> specta-go/src/lib.rs:15:13 | 15 | fn datatype(t: &DataType) -> Result<String, String> { | ^ help: if this is intentional, prefix it with an underscore: `_t` | = note: `#[warn(unused_variables)]` on by default
unused variable: `tag`: specta-kotlin/src/lib.rs#L66
warning: unused variable: `tag` --> specta-kotlin/src/lib.rs:66:17 | 66 | let tag = s.tag(); | ^^^ help: if this is intentional, prefix it with an underscore: `_tag`
unused variable: `fields`: specta-kotlin/src/lib.rs#L65
warning: unused variable: `fields` --> specta-kotlin/src/lib.rs:65:17 | 65 | let fields = s.fields(); | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_fields`
unused variable: `generics`: specta-kotlin/src/lib.rs#L64
warning: unused variable: `generics` --> specta-kotlin/src/lib.rs:64:17 | 64 | let generics = s.generics(); | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_generics`
unused variable: `name`: specta-kotlin/src/lib.rs#L63
warning: unused variable: `name` --> specta-kotlin/src/lib.rs:63:17 | 63 | let name = s.name(); | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` | = note: `#[warn(unused_variables)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: specta-util/src/type_collection.rs#L40
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-util/src/type_collection.rs:40:29 | 40 | let dt = export(&mut type_map); | ^^^^^^^^^^^^^ help: change this to: `type_map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
`todo` should not be present in production code: specta-openapi/src/lib.rs#L270
warning: `todo` should not be present in production code --> specta-openapi/src/lib.rs:270:13 | 270 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-openapi/src/lib.rs#L264
warning: `todo` should not be present in production code --> specta-openapi/src/lib.rs:264:17 | 264 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-openapi/src/lib.rs#L245
warning: `todo` should not be present in production code --> specta-openapi/src/lib.rs:245:13 | 245 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-openapi/src/lib.rs#L168
warning: `todo` should not be present in production code --> specta-openapi/src/lib.rs:168:13 | 168 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-openapi/src/lib.rs#L120
warning: `todo` should not be present in production code --> specta-openapi/src/lib.rs:120:20 | 120 | tys => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`
returning the result of a `let` binding from a block: specta-openapi/src/lib.rs#L93
warning: returning the result of a `let` binding from a block --> specta-openapi/src/lib.rs:93:13 | 91 | let schema = to_openapi(def); | ----------------------------- unnecessary `let` binding 92 | // schema.schema_data.nullable = true; // TODO 93 | schema | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-W clippy::let-and-return` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::let_and_return)]` help: return the expression directly | 91 ~ 92 | // schema.schema_data.nullable = true; // TODO 93 ~ to_openapi(def) |
this `impl` can be derived: specta-util/src/type_collection.rs#L11
warning: this `impl` can be derived --> specta-util/src/type_collection.rs:11:1 | 11 | / impl Default for TypeCollection { 12 | | fn default() -> Self { 13 | | Self { 14 | | types: HashMap::new(), 15 | | } 16 | | } 17 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-W clippy::derivable-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::derivable_impls)]` = help: remove the manual implementation... help: ...and instead derive it | 7 + #[derive(Default)] 8 | pub struct TypeCollection { |
very complex type used. Consider factoring parts into `type` definitions: specta-util/src/export.rs#L11
warning: very complex type used. Consider factoring parts into `type` definitions --> specta-util/src/export.rs:11:15 | 11 | static TYPES: OnceLock<Mutex<HashMap<SpectaID, fn(&mut TypeMap) -> NamedDataType>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `-W clippy::type-complexity` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::type_complexity)]`
`todo` should not be present in production code: specta-swift/src/lib.rs#L110
warning: `todo` should not be present in production code --> specta-swift/src/lib.rs:110:14 | 110 | _ => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo
`todo` should not be present in production code: specta-swift/src/lib.rs#L107
warning: `todo` should not be present in production code --> specta-swift/src/lib.rs:107:13 | 107 | todo!(); | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`
this expression creates a reference which is immediately dereferenced by the compiler: specta-swift/src/lib.rs#L50
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-swift/src/lib.rs:50:82 | 50 | DataType::Map(t) => format!("[{}: {}]", datatype(&t.key_ty())?, datatype(&t.value_ty())?), | ^^^^^^^^^^^^^ help: change this to: `t.value_ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-swift/src/lib.rs#L50
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-swift/src/lib.rs:50:58 | 50 | DataType::Map(t) => format!("[{}: {}]", datatype(&t.key_ty())?, datatype(&t.value_ty())?), | ^^^^^^^^^^^ help: change this to: `t.key_ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-swift/src/lib.rs#L38
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-swift/src/lib.rs:38:55 | 38 | DataType::List(t) => format!("[{}]", datatype(&t.ty())?), | ^^^^^^^ help: change this to: `t.ty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
package `specta-zod` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-serde/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
package `specta-zod` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-util/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
package `specta-zod` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-openapi/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
package `specta-zod` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-swift/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
unused variable: `generics`: specta-openapi/src/lib.rs#L256
warning: unused variable: `generics` --> specta-openapi/src/lib.rs:256:13 | 256 | generics => { | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_generics`
unused variable: `e`: specta-openapi/src/lib.rs#L170
warning: unused variable: `e` --> specta-openapi/src/lib.rs:170:24 | 170 | DataType::Enum(e) => { | ^ help: if this is intentional, prefix it with an underscore: `_e`
unused variable: `s`: specta-swift/src/lib.rs#L65
warning: unused variable: `s` --> specta-swift/src/lib.rs:65:26 | 65 | DataType::Struct(s) => { | ^ help: if this is intentional, prefix it with an underscore: `_s` | = note: `#[warn(unused_variables)]` on by default
unused variable: `name`: specta-openapi/src/lib.rs#L124
warning: unused variable: `name` --> specta-openapi/src/lib.rs:124:17 | 124 | let name = s.name(); | ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
unused variable: `fields`: specta-openapi/src/lib.rs#L123
warning: unused variable: `fields` --> specta-openapi/src/lib.rs:123:17 | 123 | let fields = s.fields(); | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_fields`
unused variable: `tys`: specta-openapi/src/lib.rs#L120
warning: unused variable: `tys` --> specta-openapi/src/lib.rs:120:13 | 120 | tys => todo!(), | ^^^ help: if this is intentional, prefix it with an underscore: `_tys` | = note: `#[warn(unused_variables)]` on by default
returning the result of a `let` binding from a block: specta/src/type/impls.rs#L421
warning: returning the result of a `let` binding from a block --> specta/src/type/impls.rs:421:37 | 420 | ... let ty = <u32 as Type>::reference(type_map, &[]).inner; | ------------------------------------------------------- unnecessary `let` binding 421 | ... ty | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 420 ~ 421 ~ <u32 as Type>::reference(type_map, &[]).inner |
returning the result of a `let` binding from a block: specta/src/type/impls.rs#L408
warning: returning the result of a `let` binding from a block --> specta/src/type/impls.rs:408:37 | 407 | ... let ty = <u64 as Type>::reference(type_map, &[]).inner; | ------------------------------------------------------- unnecessary `let` binding 408 | ... ty | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 407 ~ 408 ~ <u64 as Type>::reference(type_map, &[]).inner |
returning the result of a `let` binding from a block: specta/src/type/impls.rs#L339
warning: returning the result of a `let` binding from a block --> specta/src/type/impls.rs:339:37 | 338 | ... let ty = <u32 as Type>::reference(type_map, &[]).inner; | ------------------------------------------------------- unnecessary `let` binding 339 | ... ty | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return help: return the expression directly | 338 ~ 339 ~ <u32 as Type>::reference(type_map, &[]).inner |
returning the result of a `let` binding from a block: specta/src/type/impls.rs#L326
warning: returning the result of a `let` binding from a block --> specta/src/type/impls.rs:326:37 | 325 | ... let ty = <i64 as Type>::reference(type_map, &[]).inner; | ------------------------------------------------------- unnecessary `let` binding 326 | ... ty | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` implied by `#[warn(clippy::all)]` help: return the expression directly | 325 ~ 326 ~ <i64 as Type>::reference(type_map, &[]).inner |
accessing first element with `generics.get(0)`: specta/src/type/impls.rs#L165
warning: accessing first element with `generics.get(0)` --> specta/src/type/impls.rs:165:17 | 165 | / generics 166 | | .get(0) | |___________________________^ help: try: `generics.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `generics.get(0)`: specta/src/type/impls.rs#L153
warning: accessing first element with `generics.get(0)` --> specta/src/type/impls.rs:153:18 | 153 | ty = generics.get(0).cloned() | ^^^^^^^^^^^^^^^ help: try: `generics.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` implied by `#[warn(clippy::all)]`
unnecessary use of `get(&sid).is_none()`: specta/src/datatype/reference.rs#L22
warning: unnecessary use of `get(&sid).is_none()` --> specta/src/datatype/reference.rs:22:21 | 22 | if type_map.map.get(&sid).is_none() { | -------------^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!type_map.map.contains_key(&sid)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` implied by `#[warn(clippy::all)]`
this function has too many arguments (8/7): specta/src/internal.rs#L235
warning: this function has too many arguments (8/7) --> specta/src/internal.rs:235:5 | 235 | / pub fn get_fn_datatype<TMarker, T: Function<TMarker>>( 236 | | _: T, 237 | | asyncness: bool, 238 | | name: Cow<'static, str>, ... | 243 | | no_return_type: bool, 244 | | ) -> FunctionDataType { | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` implied by `#[warn(clippy::all)]`
`panic` should not be present in production code: specta/src/internal/interop.rs#L344
warning: `panic` should not be present in production code --> specta/src/internal/interop.rs:344:32 | 344 | DataType::Result(_) => panic!("Specta v1 does not support Result types"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
`panic` should not be present in production code: specta/src/internal/interop.rs#L44
warning: `panic` should not be present in production code --> specta/src/internal/interop.rs:44:37 | 44 | LiteralType::char(_) => panic!("Specta v1 does not support char literals"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
`panic` should not be present in production code: specta/src/internal/interop.rs#L13
warning: `panic` should not be present in production code --> specta/src/internal/interop.rs:13:30 | 13 | DataType::Unknown => panic!("Specta v1 does not support unknown types"), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic note: the lint level is defined here --> specta/src/lib.rs:3:43 | 3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs | ^^^^^^^^^^^^^
package `specta-zod` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
needless `fn main` in doctest: specta/src/./docs.md#L22
warning: needless `fn main` in doctest --> specta/src/./docs.md:22:1 | 22 | / use specta::{*, ts::*}; 23 | | 24 | | #[derive(Type)] 25 | | pub struct MyCustomType { ... | 33 | | ); 34 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main note: the lint level is defined here --> specta/src/lib.rs:3:9 | 3 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic)] // TODO: missing_docs | ^^^^^^^^^^^ = note: `#[warn(clippy::needless_doctest_main)]` implied by `#[warn(clippy::all)]`
unused variable: `name`: specta/src/internal/interop.rs#L112
warning: unused variable: `name` --> specta/src/internal/interop.rs:112:32 | 112 | .map(|(name, v)| match v.inner() { | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` | = note: `#[warn(unused_variables)]` on by default
used `unwrap()` on an `Option` value: specta-macros/src/type/struct.rs#L163
warning: used `unwrap()` on an `Option` value --> specta-macros/src/type/struct.rs:163:67 | 163 | ... let field_ident_str = unraw_raw_ident(field.ident.as_ref().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
used `unwrap()` on an `Option` value: specta-macros/src/type/struct.rs#L163
warning: used `unwrap()` on an `Option` value --> specta-macros/src/type/struct.rs:163:67 | 163 | ... let field_ident_str = unraw_raw_ident(field.ident.as_ref().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L241
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:241:29 | 241 | let generics = generics(&crate_ref, quote!(&[#(#generic_var_idents),*])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L241
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:241:29 | 241 | let generics = generics(&crate_ref, quote!(&[#(#generic_var_idents),*])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
used `unwrap()` on an `Option` value: specta-macros/src/type/generics.rs#L205
warning: used `unwrap()` on an `Option` value --> specta-macros/src/type/generics.rs:205:31 | 205 | let generic_args = match &path.segments.last().unwrap().arguments { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
used `unwrap()` on an `Option` value: specta-macros/src/type/generics.rs#L205
warning: used `unwrap()` on an `Option` value --> specta-macros/src/type/generics.rs:205:31 | 205 | let generic_args = match &path.segments.last().unwrap().arguments { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L192
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:192:17 | 192 | &crate_ref, | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L192
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:192:17 | 192 | &crate_ref, | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L169
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:169:37 | 169 | let generics = generics(&crate_ref, quote!(&[])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L169
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:169:37 | 169 | let generics = generics(&crate_ref, quote!(&[])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L151
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:151:37 | 151 | let generics = generics(&crate_ref, quote!(&[#elem_var_ident])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L151
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:151:37 | 151 | let generics = generics(&crate_ref, quote!(&[#elem_var_ident])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L131
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:131:37 | 131 | let generics = generics(&crate_ref, quote!(&[#(#generic_var_idents),*])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
this expression creates a reference which is immediately dereferenced by the compiler: specta-macros/src/type/generics.rs#L131
warning: this expression creates a reference which is immediately dereferenced by the compiler --> specta-macros/src/type/generics.rs:131:37 | 131 | let generics = generics(&crate_ref, quote!(&[#(#generic_var_idents),*])); | ^^^^^^^^^^ help: change this to: `crate_ref` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`
used `unwrap()` on an `Option` value: specta-macros/src/type/enum.rs#L151
warning: used `unwrap()` on an `Option` value --> specta-macros/src/type/enum.rs:151:49 | 151 | ... unraw_raw_ident(field.ident.as_ref().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
`todo` should not be present in production code: specta-macros/src/type/enum.rs#L77
warning: `todo` should not be present in production code --> specta-macros/src/type/enum.rs:77:30 | 77 | _ => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`
used `unwrap()` on an `Option` value: specta-macros/src/type/enum.rs#L151
warning: used `unwrap()` on an `Option` value --> specta-macros/src/type/enum.rs:151:49 | 151 | ... unraw_raw_ident(field.ident.as_ref().unwrap()); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is `None`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
`todo` should not be present in production code: specta-macros/src/type/enum.rs#L77
warning: `todo` should not be present in production code --> specta-macros/src/type/enum.rs:77:30 | 77 | _ => todo!(), | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#todo = note: requested on the command line with `-W clippy::todo`
field assignment outside of initializer for an instance created with Default::default(): specta-macros/src/type/attr/variant.rs#L32
warning: field assignment outside of initializer for an instance created with Default::default() --> specta-macros/src/type/attr/variant.rs:32:9 | 32 | result.common = CommonAttr::from_attrs(attrs)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `r#type::attr::variant::VariantAttr { common: CommonAttr::from_attrs(attrs)?, ..Default::default() }` and removing relevant reassignments --> specta-macros/src/type/attr/variant.rs:31:9 | 31 | let mut result = Self::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/variant.rs:18:1 | 18 | / impl_parse! { 19 | | VariantAttr(attr, out) { 20 | | "rename_all" => out.rename_all = out.rename_all.take().or(Some(attr.parse_inflection()?)), 21 | | "rename" => out.rename = out.rename.take().or(Some(attr.parse_string()?.to_token_stream())), ... | 26 | | } 27 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
field assignment outside of initializer for an instance created with Default::default(): specta-macros/src/type/attr/field.rs#L54
warning: field assignment outside of initializer for an instance created with Default::default() --> specta-macros/src/type/attr/field.rs:54:9 | 54 | result.common = CommonAttr::from_attrs(attrs)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `r#type::attr::field::FieldAttr { common: CommonAttr::from_attrs(attrs)?, ..Default::default() }` and removing relevant reassignments --> specta-macros/src/type/attr/field.rs:53:9 | 53 | let mut result = Self::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
field assignment outside of initializer for an instance created with Default::default(): specta-macros/src/type/attr/variant.rs#L32
warning: field assignment outside of initializer for an instance created with Default::default() --> specta-macros/src/type/attr/variant.rs:32:9 | 32 | result.common = CommonAttr::from_attrs(attrs)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `r#type::attr::variant::VariantAttr { common: CommonAttr::from_attrs(attrs)?, ..Default::default() }` and removing relevant reassignments --> specta-macros/src/type/attr/variant.rs:31:9 | 31 | let mut result = Self::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/variant.rs:18:1 | 18 | / impl_parse! { 19 | | VariantAttr(attr, out) { 20 | | "rename_all" => out.rename_all = out.rename_all.take().or(Some(attr.parse_inflection()?)), 21 | | "rename" => out.rename = out.rename.take().or(Some(attr.parse_string()?.to_token_stream())), ... | 26 | | } 27 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/field.rs:20:1 | 20 | / impl_parse! { 21 | | FieldAttr(attr, out) { 22 | | "rename" => { 23 | | let attr = attr.parse_string()?; ... | 48 | | } 49 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
field assignment outside of initializer for an instance created with Default::default(): specta-macros/src/type/attr/field.rs#L54
warning: field assignment outside of initializer for an instance created with Default::default() --> specta-macros/src/type/attr/field.rs:54:9 | 54 | result.common = CommonAttr::from_attrs(attrs)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `r#type::attr::field::FieldAttr { common: CommonAttr::from_attrs(attrs)?, ..Default::default() }` and removing relevant reassignments --> specta-macros/src/type/attr/field.rs:53:9 | 53 | let mut result = Self::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/field.rs:20:1 | 20 | / impl_parse! { 21 | | FieldAttr(attr, out) { 22 | | "rename" => { 23 | | let attr = attr.parse_string()?; ... | 48 | | } 49 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/enum.rs:25:1 | 25 | / impl_parse! { 26 | | EnumAttr(attr, out) { 27 | | // "tag" was already passed in the container so we don't need to do anything here 28 | | "content" => out.content = out.content.take().or(Some(attr.parse_string()?)), ... | 31 | | } 32 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
field assignment outside of initializer for an instance created with Default::default(): specta-macros/src/type/attr/container.rs#L54
warning: field assignment outside of initializer for an instance created with Default::default() --> specta-macros/src/type/attr/container.rs:54:9 | 54 | result.common = CommonAttr::from_attrs(attrs)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `r#type::attr::container::ContainerAttr { common: CommonAttr::from_attrs(attrs)?, ..Default::default() }` and removing relevant reassignments --> specta-macros/src/type/attr/container.rs:53:9 | 53 | let mut result = Self::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default = note: `-W clippy::field-reassign-with-default` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::field_reassign_with_default)]`
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/enum.rs:25:1 | 25 | / impl_parse! { 26 | | EnumAttr(attr, out) { 27 | | // "tag" was already passed in the container so we don't need to do anything here 28 | | "content" => out.content = out.content.take().or(Some(attr.parse_string()?)), ... | 31 | | } 32 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
field assignment outside of initializer for an instance created with Default::default(): specta-macros/src/type/attr/container.rs#L54
warning: field assignment outside of initializer for an instance created with Default::default() --> specta-macros/src/type/attr/container.rs:54:9 | 54 | result.common = CommonAttr::from_attrs(attrs)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `r#type::attr::container::ContainerAttr { common: CommonAttr::from_attrs(attrs)?, ..Default::default() }` and removing relevant reassignments --> specta-macros/src/type/attr/container.rs:53:9 | 53 | let mut result = Self::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default = note: `-W clippy::field-reassign-with-default` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::field_reassign_with_default)]`
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/container.rs:24:1 | 24 | / impl_parse! { 25 | | ContainerAttr(attr, out) { 26 | | "rename_all" => out.rename_all = out.rename_all.take().or(Some(attr.parse_inflection()?)), 27 | | "rename" => { ... | 48 | | } 49 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/utils.rs#L202
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/utils.rs:202:24 | 202 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-macros/src/type/attr/container.rs:24:1 | 24 | / impl_parse! { 25 | | ContainerAttr(attr, out) { 26 | | "rename_all" => out.rename_all = out.rename_all.take().or(Some(attr.parse_inflection()?)), 27 | | "rename" => { ... | 48 | | } 49 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
length comparison to zero: specta-datatype-from/src/data_type_from/mod.rs#L24
warning: length comparison to zero --> specta-datatype-from/src/data_type_from/mod.rs:24:8 | 24 | if generics.params.len() > 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!generics.params.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `-W clippy::len-zero` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::len_zero)]`
called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead: specta-macros/src/type/attr/common.rs#L75
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead --> specta-macros/src/type/attr/common.rs:75:32 | 75 | let note = attr | ________________________________^ 76 | | .iter() 77 | | .filter(|attr| attr.key == "note") 78 | | .next() | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next help: try | 75 ~ let note = attr 76 + .iter().find(|attr| attr.key == "note") |
called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead: specta-macros/src/type/attr/common.rs#L75
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead --> specta-macros/src/type/attr/common.rs:75:32 | 75 | let note = attr | ________________________________^ 76 | | .iter() 77 | | .filter(|attr| attr.key == "note") 78 | | .next() | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next help: try | 75 ~ let note = attr 76 + .iter().find(|attr| attr.key == "note") |
called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead: specta-macros/src/type/attr/common.rs#L61
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead --> specta-macros/src/type/attr/common.rs:61:33 | 61 | let since = attr | _________________________________^ 62 | | .iter() 63 | | .filter(|attr| attr.key == "since") 64 | | .next() | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next help: try | 61 ~ let since = attr 62 + .iter().find(|attr| attr.key == "since") |
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-datatype-from/src/utils.rs#L221
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-datatype-from/src/utils.rs:221:24 | 221 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-datatype-from/src/data_type_from/attr/field.rs:13:1 | 13 | / impl_parse! { 14 | | FieldAttr(attr, out) { 15 | | "skip" => out.skip = true, 16 | | "rename" => { ... | 22 | | } 23 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead: specta-macros/src/type/attr/common.rs#L61
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead --> specta-macros/src/type/attr/common.rs:61:33 | 61 | let since = attr | _________________________________^ 62 | | .iter() 63 | | .filter(|attr| attr.key == "since") 64 | | .next() | |_______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next help: try | 61 ~ let since = attr 62 + .iter().find(|attr| attr.key == "since") |
called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead: specta-macros/src/type/attr/common.rs#L46
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead --> specta-macros/src/type/attr/common.rs:46:35 | 46 | if let Some(attr_value) = attrs.iter().filter(|attr| attr.key == "deprecated").next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attrs.iter().find(|attr| attr.key == "deprecated")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next = note: `-W clippy::filter-next` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::filter_next)]`
called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead: specta-macros/src/type/attr/common.rs#L46
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead --> specta-macros/src/type/attr/common.rs:46:35 | 46 | if let Some(attr_value) = attrs.iter().filter(|attr| attr.key == "deprecated").next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `attrs.iter().find(|attr| attr.key == "deprecated")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next = note: `-W clippy::filter-next` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::filter_next)]`
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-datatype-from/src/utils.rs#L221
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-datatype-from/src/utils.rs:221:24 | 221 | attrs: &mut Vec<crate::utils::Attribute>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [crate::utils::Attribute]` | ::: specta-datatype-from/src/data_type_from/attr/container.rs:12:1 | 12 | / impl_parse! { 13 | | ContainerAttr(attr, out) { 14 | | "crate" => out.crate_name = out.crate_name.take().or(Some(attr.parse_path()?.into_token_stream())), 15 | | } 16 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-W clippy::ptr-arg` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]` = note: this warning originates in the macro `impl_parse` (in Nightly builds, run with -Z macro-backtrace for more info)
calling `push_str()` using a single-character string literal: specta-macros/src/type/attr/common.rs#L38
warning: calling `push_str()` using a single-character string literal --> specta-macros/src/type/attr/common.rs:38:21 | 38 | s.push_str("\n"); | ^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `-W clippy::single-char-add-str` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::single_char_add_str)]`
calling `push_str()` using a single-character string literal: specta-macros/src/type/attr/common.rs#L38
warning: calling `push_str()` using a single-character string literal --> specta-macros/src/type/attr/common.rs:38:21 | 38 | s.push_str("\n"); | ^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `s.push('\n')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `-W clippy::single-char-add-str` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::single_char_add_str)]`
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/type/attr/common.rs#L32
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/type/attr/common.rs:32:30 | 32 | pub fn from_attrs(attrs: &mut Vec<Attribute>) -> Result<Self> { | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Attribute]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-W clippy::ptr-arg` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do: specta-macros/src/type/attr/common.rs#L32
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> specta-macros/src/type/attr/common.rs:32:30 | 32 | pub fn from_attrs(attrs: &mut Vec<Attribute>) -> Result<Self> { | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [Attribute]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-W clippy::ptr-arg` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`
used `unwrap()` on a `Result` value: specta-macros/src/specta.rs#L66
warning: used `unwrap()` on a `Result` value --> specta-macros/src/specta.rs:66:9 | 66 | TokenStream::from_str(&s).unwrap() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used = note: requested on the command line with `-W clippy::unwrap-used`
used `unwrap()` on a `Result` value: specta-macros/src/specta.rs#L66
warning: used `unwrap()` on a `Result` value --> specta-macros/src/specta.rs:66:9 | 66 | TokenStream::from_str(&s).unwrap() | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: if this value is an `Err`, it will panic = help: consider using `expect()` to provide a better panic message = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used = note: requested on the command line with `-W clippy::unwrap-used`
redundant pattern matching, consider using `is_some()`: specta-macros/src/specta.rs#L40
warning: redundant pattern matching, consider using `is_some()` --> specta-macros/src/specta.rs:40:30 | 40 | let function_asyncness = match function.sig.asyncness { | ______________________________^ 41 | | Some(_) => true, 42 | | None => false, 43 | | }; | |_____^ help: try: `function.sig.asyncness.is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `-W clippy::redundant-pattern-matching` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::redundant_pattern_matching)]`
redundant pattern matching, consider using `is_some()`: specta-macros/src/specta.rs#L40
warning: redundant pattern matching, consider using `is_some()` --> specta-macros/src/specta.rs:40:30 | 40 | let function_asyncness = match function.sig.asyncness { | ______________________________^ 41 | | Some(_) => true, 42 | | None => false, 43 | | }; | |_____^ help: try: `function.sig.asyncness.is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `-W clippy::redundant-pattern-matching` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::redundant_pattern_matching)]`
package `specta-zod` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-zod` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-serde` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-zod` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-zod` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-util` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-util` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-typescript` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-typescript` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-swift` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-swift` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
package `specta` is missing `package.readme` metadata: specta-macros/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
package `specta-serde` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-serde` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-rust` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-rust` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-openapi` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-openapi` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-kotlin` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-kotlin` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-go` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-go` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta-datatype-from` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta-datatype-from` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata
package `specta` is missing `package.readme` metadata: specta-datatype-from/src/lib.rs#L1
warning: package `specta` is missing `package.readme` metadata | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cargo_common_metadata = note: `-W clippy::cargo-common-metadata` implied by `-W clippy::cargo` = help: to override `-W clippy::cargo` add `#[allow(clippy::cargo_common_metadata)]`
function `then_option` is never used: specta-macros/src/utils.rs#L293
warning: function `then_option` is never used --> specta-macros/src/utils.rs:293:8 | 293 | pub fn then_option(condition: bool, inner: TokenStream) -> TokenStream { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `then_option` is never used: specta-macros/src/utils.rs#L293
warning: function `then_option` is never used --> specta-macros/src/utils.rs:293:8 | 293 | pub fn then_option(condition: bool, inner: TokenStream) -> TokenStream { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
method `apply` is never used: specta-datatype-from/src/utils.rs#L291
warning: method `apply` is never used --> specta-datatype-from/src/utils.rs:291:12 | 290 | impl Inflection { | --------------- method in this implementation 291 | pub fn apply(self, string: &str) -> String { | ^^^^^
enum `Inflection` is never used: specta-datatype-from/src/utils.rs#L279
warning: enum `Inflection` is never used --> specta-datatype-from/src/utils.rs:279:10 | 279 | pub enum Inflection { | ^^^^^^^^^^ | = note: `Inflection` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
function `unraw_raw_ident` is never used: specta-datatype-from/src/utils.rs#L269
warning: function `unraw_raw_ident` is never used --> specta-datatype-from/src/utils.rs:269:8 | 269 | pub fn unraw_raw_ident(ident: &Ident) -> String { | ^^^^^^^^^^^^^^^
methods `parse_bool` and `parse_inflection` are never used: specta-datatype-from/src/utils.rs#L72
warning: methods `parse_bool` and `parse_inflection` are never used --> specta-datatype-from/src/utils.rs:72:12 | 52 | impl Attribute { | -------------- methods in this implementation ... 72 | pub fn parse_bool(&self) -> Result<bool> { | ^^^^^^^^^^ ... 92 | pub fn parse_inflection(&self) -> Result<Inflection> { | ^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
`#[macro_use]` only has an effect on `extern crate` and modules: specta-datatype-from/src/utils.rs#L215
warning: `#[macro_use]` only has an effect on `extern crate` and modules --> specta-datatype-from/src/utils.rs:215:1 | 215 | #[macro_use] | ^^^^^^^^^^^^ | = note: `#[warn(unused_attributes)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
clippy
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/