minor #166
Annotations
16 warnings
`panic` should not be present in production code:
src/lang/ts/mod.rs#L206
warning: `panic` should not be present in production code
--> src/lang/ts/mod.rs:206:44
|
206 | .unwrap_or_else(|| panic!("Type {} has no value!", r.name));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
|
`panic` should not be present in production code:
src/lang/ts/mod.rs#L204
warning: `panic` should not be present in production code
--> src/lang/ts/mod.rs:204:44
|
204 | .unwrap_or_else(|| panic!("Type {} not found!", r.name))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic
note: the lint level is defined here
--> src/lib.rs:58:43
|
58 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic, missing_docs)]
| ^^^^^^^^^^^^^
|
deref on an immutable reference:
src/lang/ts/mod.rs#L124
warning: deref on an immutable reference
--> src/lang/ts/mod.rs:124:46
|
124 | (!generics.is_empty()).then_some(&*generics)
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
help: if you would like to reborrow, try removing `&*`
|
124 | (!generics.is_empty()).then_some(generics)
| ~~~~~~~~
help: if you would like to deref, try using `&**`
|
124 | (!generics.is_empty()).then_some(&**generics)
| ~~~~~~~~~~~
|
deref on an immutable reference:
src/lang/ts/mod.rs#L121
warning: deref on an immutable reference
--> src/lang/ts/mod.rs:121:46
|
121 | (!generics.is_empty()).then_some(&*generics)
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` implied by `#[warn(clippy::all)]`
help: if you would like to reborrow, try removing `&*`
|
121 | (!generics.is_empty()).then_some(generics)
| ~~~~~~~~
help: if you would like to deref, try using `&**`
|
121 | (!generics.is_empty()).then_some(&**generics)
| ~~~~~~~~~~~
|
useless conversion to the same type: `export::export::TypesIter`:
src/export/ts.rs#L19
warning: useless conversion to the same type: `export::export::TypesIter`
--> src/export/ts.rs:19:17
|
19 | let types = get_types()?
| _________________^
20 | | .into_iter()
| |____________________^ help: consider removing `.into_iter()`: `get_types()?`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` implied by `#[warn(clippy::all)]`
|
module has the same name as its containing module:
src/export/mod.rs#L1
warning: module has the same name as its containing module
--> src/export/mod.rs:1:1
|
1 | mod export;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` implied by `#[warn(clippy::all)]`
|
missing documentation for a struct field:
src/datatype/tuple.rs#L19
warning: missing documentation for a struct field
--> src/datatype/tuple.rs:19:9
|
19 | generics: Vec<Cow<'static, str>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a struct field:
src/datatype/tuple.rs#L18
warning: missing documentation for a struct field
--> src/datatype/tuple.rs:18:9
|
18 | fields: Vec<DataType>,
| ^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a struct field:
src/datatype/object.rs#L21
warning: missing documentation for a struct field
--> src/datatype/object.rs:21:5
|
21 | pub tag: Option<Cow<'static, str>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a struct field:
src/datatype/object.rs#L20
warning: missing documentation for a struct field
--> src/datatype/object.rs:20:5
|
20 | pub fields: Vec<ObjectField>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
missing documentation for a struct field:
src/datatype/object.rs#L19
warning: missing documentation for a struct field
--> src/datatype/object.rs:19:5
|
19 | pub generics: Vec<Cow<'static, str>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:58:58
|
58 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic, missing_docs)]
| ^^^^^^^^^^^^
|
constant `RESERVED_IDENTS` is never used:
src/lang/ts/reserved_terms.rs#L66
warning: constant `RESERVED_IDENTS` is never used
--> src/lang/ts/reserved_terms.rs:66:18
|
66 | pub(super) const RESERVED_IDENTS: &[&str] = &[
| ^^^^^^^^^^^^^^^
|
method `generics` is never used:
src/datatype/enum.rs#L35
warning: method `generics` is never used
--> src/datatype/enum.rs:35:19
|
34 | impl EnumType {
| ------------- method in this implementation
35 | pub(crate) fn generics(&self) -> &Vec<Cow<'static, str>> {
| ^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
unused variable: `generics`:
src/lang/ts/mod.rs#L290
warning: unused variable: `generics`
--> src/lang/ts/mod.rs:290:36
|
290 | TupleType::Named { fields, generics } => match &fields[..] {
| ^^^^^^^^ help: try ignoring the field: `generics: _`
|
= note: `#[warn(unused_variables)]` on by default
|
unneeded unit return type:
src/export/export.rs#L49
warning: unneeded unit return type
--> src/export/export.rs:49:30
|
49 | pub fn register_ty<T: Type>() -> () {
| ^^^^^^ help: remove the `-> ()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
note: the lint level is defined here
--> src/lib.rs:58:9
|
58 | #![warn(clippy::all, clippy::unwrap_used, clippy::panic, missing_docs)]
| ^^^^^^^^^^^
= note: `#[warn(clippy::unused_unit)]` implied by `#[warn(clippy::all)]`
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|