Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion Error Fixed True === False #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Assertion Error Fixed True === False #342

wants to merge 1 commit into from

Conversation

deveshmehta7
Copy link

Assertion Error Fixed True === False

@coolaj86
Copy link

coolaj86 commented Oct 9, 2018

This doesn't pass tests on Node v8.x. Do you think you could find an approach that will work in both v8.x and v10.x?

@coolaj86 coolaj86 mentioned this pull request Oct 9, 2018
Closed
@JamesIves
Copy link

2.1.1 of spdy-transport includes the fix for this error, they bumped the version number on the registry so this PR should point to that instead of your personal fork: https://github.com/spdy-http2/spdy-transport/releases/tag/v2.1.1

@wojtekmaj
Copy link

spdy-transport 3.0.0 is now used so this may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deveshmehta7 @coolaj86 @JamesIves @wojtekmaj @deveshMantra